GNOME Bugzilla – Bug 84062
make _gtk_text_util_append_special_char_menuitems public
Last modified: 2013-08-14 01:39:28 UTC
This is known. The IM support was disabled because the api has changed for gtk2. I would like to get it reenabled but need some help. At a minimium I can't test this.
Sorry, it's my mistake. I've accidentaly hit enter while submitting #84064 with wrong subject. I can input Korean characters in spreadsheet cell though they're not displayed.
I wish it were that simple. IM support for in cell editing is disabled. We need to fix it.
Created attachment 8990 [details] Screenshot : entering Korean characters into cell with XIM
Ah you don't believe me :) I've attached above screenshot showing Korean text written in spread cell. They're garbled but at least I can input them with XIM. I've checked out source from CVS yesterday. And it says it's version 1.1.6
I commented out the code myself, something else is going on.
Created attachment 10475 [details] [review] im patch (depends on my pango patch)
The patch which can use im by cell-draw.c although it is dependent on the my patch of pango. (#87833, atach_id=10474)
Created attachment 10476 [details] screenshot, input japanese string using a xim im module
I've applied most of the patch. However, there are a few bits that need some work. 1) gnm_canvas_delete_surrounding_cb & gnm_canvas_retrieve_surrounding_cb These appear useless. Why do we need them ? Is the patch trying to disable handling those signals elsewhere ? 2) The patch to gui-utils is in mostly the wrong place. That code is shared by everything that generates a popup menu (eg col/row headers, and objects). We may need some special magic to add IM method support for the sheet, but it needs to be better wrapped. 3) _gtk_text_util_append_special_char_menuitems is an internal routine. It will not be publicly available on some systems. Why do we need this ? and if we do, can it be added to the public interface of gtk+ ? Thanks for the patch
Thank you for evaluating a patch. Since the patch had a problem in the input, it updated only a few. It is kind when I have you reappraise. 1) Probably, it is unnecessary now. It seems to work with IM which I am using. Is it really unnecessary or not? Or are any codes written or not? I try and test other IM than currently used usually. 2) Sure. Where to put it in. I do not have a good idea. 3) I'm sorry, That's right. A problem is not in the input itself. Please disable a #if block until a good idea.
Created attachment 11333 [details] [review] updated patch
Hmm, the new patch has several things that confuse me. I'll commit what seems valid in the original then we can work with cvs in smaller pieces for the rest.
*** Bug 67073 has been marked as a duplicate of this bug. ***
Adding Y Nakai, the author of IM support in 1.0.x to the CC list to get his perspective on things. Most of the 1st patch is in CVS now with the exception of the IM method selection menu. havoc : Any thoughts on reasonable way to do _gtk_text_util_append_special_char_menuitems ?
_gtk_text_util_append_special_char_menuitems probably does need to be public. Or something like it. We should get a bug on the 2.2 freeze milestone ASAP.
Re-opening. I don't see any open questions.
I was about to file a new bug regarding Thai XIM before finding the discussions going here. So, I won't file a new one. I do want to have the gnm_canvas_retrieve_surrounding_cb() and gnm_canvas_delete_surrounding() so that Thai XIM can perform to its maximum, as the XIM is context-sensitive. (Please refer to bug #101814 for details.) With my summarized GTK+ patch (attch. #13303) and XFree86 patch (attch. #13304) in bug #101814 applied, I can now work on the missing callbacks in GnmCanvas.
Created attachment 13361 [details] [review] surrounding callbacks patch
Ok. Patch looks good. Other than the context menu extension what are we missing ?
As far as I can tell _gtk_text_util_append_special_char_menuitems is still private.
*** Bug 115915 has been marked as a duplicate of this bug. ***
Looks like its just blocking on the gtk changes. I'll downgrade for now.
Comment on attachment 13361 [details] [review] surrounding callbacks patch I've lost track of what this was meant to do.
This has been moulder around for far too long. Punting to gtk and retitling.
we don't have the special menuitems anymore