After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 84062 - make _gtk_text_util_append_special_char_menuitems public
make _gtk_text_util_append_special_char_menuitems public
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Widget: GtkTextView
2.7.x
Other All
: Normal enhancement
: Small API
Assigned To: Jody Goldberg
Jody Goldberg
: 67073 115915 (view as bug list)
Depends on: 94655
Blocks:
 
 
Reported: 2002-06-04 08:37 UTC by Xavier Cho
Modified: 2013-08-14 01:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot : entering Korean characters into cell with XIM (16.13 KB, image/gif)
2002-06-05 02:49 UTC, Xavier Cho
  Details
im patch (depends on my pango patch) (14.99 KB, patch)
2002-08-14 06:39 UTC, Shingo Akagaki
needs-work Details | Review
screenshot, input japanese string using a xim im module (87.70 KB, image/png)
2002-08-14 06:49 UTC, Shingo Akagaki
  Details
updated patch (16.16 KB, patch)
2002-10-01 11:14 UTC, Shingo Akagaki
none Details | Review
surrounding callbacks patch (2.14 KB, patch)
2003-01-05 15:43 UTC, Theppitak Karoonboonyanan
none Details | Review

Description Xavier Cho 2002-06-04 08:37:03 UTC

Comment 1 Jody Goldberg 2002-06-04 15:11:31 UTC
This is known.  The IM support was disabled because the api has changed for
gtk2.  I would like to get it reenabled but need some help.  At a minimium I
can't test this.
Comment 2 Xavier Cho 2002-06-05 00:41:35 UTC
 Sorry, it's my mistake. I've accidentaly hit enter while submitting
#84064 with wrong subject. I can input Korean characters in
spreadsheet cell though they're not displayed.

Comment 3 Jody Goldberg 2002-06-05 02:16:35 UTC
I wish it were that simple.
IM support for in cell editing is disabled.  We need to fix it.
Comment 4 Xavier Cho 2002-06-05 02:49:06 UTC
Created attachment 8990 [details]
Screenshot : entering Korean characters into cell with XIM
Comment 5 Xavier Cho 2002-06-05 02:50:49 UTC
Ah you don't believe me :) I've attached above screenshot showing
Korean text written in spread cell. They're garbled but at least I can
input them with XIM.

I've checked out source from CVS yesterday. And it says it's version 1.1.6
Comment 6 Jody Goldberg 2002-06-05 03:31:46 UTC
I commented out the code myself, something else is going on.
Comment 7 Shingo Akagaki 2002-08-14 06:39:01 UTC
Created attachment 10475 [details] [review]
im patch (depends on my pango patch)
Comment 8 Shingo Akagaki 2002-08-14 06:42:52 UTC
The patch which can use im by cell-draw.c although it is dependent on
the my patch of pango. (#87833, atach_id=10474)
Comment 9 Shingo Akagaki 2002-08-14 06:49:05 UTC
Created attachment 10476 [details]
screenshot, input japanese string using a xim im module
Comment 10 Jody Goldberg 2002-09-30 21:36:50 UTC
I've applied most of the patch.  However, there are a few bits that need some work.

1) gnm_canvas_delete_surrounding_cb & gnm_canvas_retrieve_surrounding_cb
   These appear useless.  Why do we need them ?  Is the patch trying to disable
   handling those signals elsewhere ?

2) The patch to gui-utils is in mostly the wrong place.  That code is shared by
   everything that generates a popup menu (eg col/row headers, and objects).
   We may need some special magic to add IM method support for the sheet, but
   it needs to be better wrapped.

3) _gtk_text_util_append_special_char_menuitems is an internal routine.  It
   will not be publicly available on some systems.  Why do we need this ?
   and if we do, can it be added to the public interface of gtk+ ?

Thanks for the patch
Comment 11 Shingo Akagaki 2002-10-01 11:12:55 UTC
Thank you for evaluating a patch.
Since the patch had a problem in the input, it updated only a few.
It is kind when I have you reappraise.

1) Probably, it is unnecessary now.
   It seems to work with IM which I am using.
   Is it really unnecessary or not? Or are any codes written or not?
   I try and test other IM than currently used usually.

2) Sure.
   Where to put it in. I do not have a good idea.

3) I'm sorry, That's right.
   A problem is not in the input itself. Please disable a #if block
until a good idea.
Comment 12 Shingo Akagaki 2002-10-01 11:14:52 UTC
Created attachment 11333 [details] [review]
updated patch
Comment 13 Jody Goldberg 2002-10-01 17:20:54 UTC
Hmm, the new patch has several things that confuse me.
I'll commit what seems valid in the original then we can work with cvs in
smaller pieces for the rest.
Comment 14 Jody Goldberg 2002-10-02 03:10:11 UTC
*** Bug 67073 has been marked as a duplicate of this bug. ***
Comment 15 Jody Goldberg 2002-10-02 03:12:15 UTC
Adding Y Nakai, the author of IM support in 1.0.x to the CC list to get his
perspective on things.  Most of the 1st patch is in CVS now with the exception
of the IM method selection menu.

havoc : Any thoughts on reasonable way to do
   _gtk_text_util_append_special_char_menuitems ?
Comment 16 Havoc Pennington 2002-10-02 03:37:03 UTC
 _gtk_text_util_append_special_char_menuitems probably does need to be 
public. Or something like it. We should get a bug on the 2.2 freeze
milestone ASAP.

Comment 17 Morten Welinder 2002-11-04 19:36:48 UTC
Re-opening.  I don't see any open questions.

Comment 18 Theppitak Karoonboonyanan 2003-01-05 15:41:03 UTC
I was about to file a new bug regarding Thai XIM before
finding the discussions going here. So, I won't file a new 
one.

I do want to have the gnm_canvas_retrieve_surrounding_cb() and
gnm_canvas_delete_surrounding() so that Thai XIM can perform
to its maximum, as the XIM is context-sensitive.
(Please refer to bug #101814 for details.)

With my summarized GTK+ patch (attch. #13303) and XFree86 
patch (attch. #13304) in bug #101814 applied, I can now
work on the missing callbacks in GnmCanvas.
Comment 19 Theppitak Karoonboonyanan 2003-01-05 15:43:36 UTC
Created attachment 13361 [details] [review]
surrounding callbacks patch
Comment 20 Jody Goldberg 2003-01-08 07:24:09 UTC
Ok.  Patch looks good.

Other than the context menu extension what are we missing ?
Comment 21 Jody Goldberg 2003-03-17 05:54:35 UTC
As far as I can tell _gtk_text_util_append_special_char_menuitems is
still private.
Comment 22 Andreas J. Guelzow 2003-07-23 21:40:36 UTC
*** Bug 115915 has been marked as a duplicate of this bug. ***
Comment 23 Jody Goldberg 2004-02-18 20:53:14 UTC
Looks like its just blocking on the gtk changes.  I'll downgrade for now.
Comment 24 Jody Goldberg 2004-08-16 21:49:02 UTC
Comment on attachment 13361 [details] [review]
surrounding callbacks patch

I've lost track of what this was meant to do.
Comment 25 Jody Goldberg 2005-08-04 02:09:22 UTC
This has been moulder around for far too long. Punting to gtk and retitling. 
Comment 26 Matthias Clasen 2013-08-14 01:39:28 UTC
we don't have the special menuitems anymore