After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 84004 - symlinks from the desktop get URI decoded
symlinks from the desktop get URI decoded
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
0.x.x [obsolete]
Other Linux
: High normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-06-03 19:22 UTC by frb
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
escape link names when getting the target uri. (882 bytes, patch)
2002-06-06 20:16 UTC, Dave Camp 		none Details | Review
same patch, variable defined at the top. (935 bytes, patch)
2002-06-06 21:33 UTC, Dave Camp 		none Details | Review

Description frb 2002-06-03 19:22:03 UTC 
If I create a symlink on the desktop to a dir with http encoding, nautilus
decodes it, and gets the name incorrect

Reproduce:
1> mkdir %7Efoo
2> Use nautilus to create a link to that dir on the desktop
3> double-click on desktop item

Actual results:
Dialog saying cannot find "/home/frb/~foo"

Expected results:
New nautilus window with contents of "/home/frb/%7Efoo"

Reproducibility:
Always
Comment 1 Idcmp 2002-06-03 22:44:44 UTC 
I can reproduce this. 31-May-2002 snap from red-carpet, rh73/x86.

Create a directory called "%2Egnome", right click on it and "Create
Shortcut".  Drag the shortcut to the desktop.  Double-click on the
shortcut and the .gnome directory is shown.

This gives me an uneasy feeling wrt security, but I can't think of an
immediately easy way to exploit it.  Trashing the symlink moves the
symlink to .Trash, deleting it deletes the symlink.
Comment 2 Luis Villa 2002-06-05 02:50:04 UTC 
Hrm... did this already get decoded? I can't find it, Alex...
Comment 3 Dave Camp 2002-06-06 20:16:26 UTC 
Created attachment 9025 [details] [review]
escape link names when getting the target uri.
Comment 4 Dave Camp 2002-06-06 20:18:05 UTC 
The attached patch uses gnome_vfs_escape_path_string to escape the
link target before making a uri out of it.
Comment 5 Dave Camp 2002-06-06 21:33:00 UTC 
Created attachment 9032 [details] [review]
same patch, variable defined at the top.
Comment 6 Luis Villa 2002-06-11 15:53:04 UTC 
when I said 'decoded' earlier I meant 'reported'
Comment 7 Alexander Larsson 2002-06-13 06:58:34 UTC 
Looks fine. Please commit.
Comment 8 Dave Camp 2002-06-13 18:29:26 UTC 
Checked in.