After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 83994 - gnomevfssrc parse "%20" of filename as ' '
gnomevfssrc parse "%20" of filename as ' '
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.3.4
Other other
: Low minor
: 0.4.0
Assigned To: Bastien Nocera
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-06-03 17:56 UTC by kz
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
correct way of handling "location" (NOT tested) (1.57 KB, patch)
2002-06-06 08:25 UTC, xavier.bestel
none Details | Review
This time it's tested. Please apply. (1.30 KB, patch)
2002-06-18 09:41 UTC, xavier.bestel
none Details | Review

Description kz 2002-06-03 17:57:43 UTC
Package: GStreamer
Severity: minor
Version: 0.3.4
Synopsis: gnomevfssrc parse "%20" of filename as ' '
Bugzilla-Product: GStreamer
Bugzilla-Component: gst-plugins

Description:
I have a file downloaded as name of "blah%20blah.mp3"
and tried simple shell script to call gst-launch with gnomevfssrc.
then, gst-launch complaint that there's no file of name
"file://home/Keizi/blash blah.mp3"




------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-06-03 13:57 -------

Unknown version unspecified in product GStreamer. Setting version to "0.3.3".
Reassigning to the default owner of the component, gstreamer-maint@bugzilla.gnome.org.

Comment 1 Benjamin Otte (Company) 2002-06-04 11:05:36 UTC
gnomevfssrc expects a URI in the location field, not a file name.

The right URI would be "blah%2520blah.mp3" in this case.

Hope someone marks this NOTABUG now :)
Comment 2 kz 2002-06-04 13:41:51 UTC
why NOTABUG? local command line is not a URI.
I think it'll be good to url-encode as well as 's/^/file:\/\/.../'.
Comment 3 Bastien Nocera 2002-06-05 14:40:29 UTC
Having to doubly-escape the URI is a bug. I'll look into this at some
point. But gst-launch is a debug tool, not a user-friendly UI.
Comment 4 xavier.bestel 2002-06-06 06:01:22 UTC
It's gst-launch's job to escape the URI if it uses gnomevfssrc, not
the user. IMHO.
Comment 5 xavier.bestel 2002-06-06 08:25:41 UTC
Created attachment 9009 [details] [review]
correct way of handling "location"  (NOT tested)
Comment 6 Andy Wingo 2002-06-07 02:55:38 UTC
that patch actually looks pretty good, although I won't be able to get
to it for a couple days. can you please test it out, xav?

and of course, it's not gst-launch's job to do anything
plugin-specific at all. i'll assume that was a typo ;)
Comment 7 David Holroyd 2002-06-07 10:06:36 UTC
Looks like the patch always escapes the given location:  Only do this
if constructing a URI from a filename; when 'location' starts as a
URI, it is either already correctly escaped, or is invalid.
Comment 8 xavier.bestel 2002-06-18 09:41:03 UTC
Created attachment 9295 [details] [review]
This time it's tested. Please apply.
Comment 9 Christian Fredrik Kalager Schaller 2002-07-02 07:21:29 UTC
Patch applied, closing bug.