GNOME Bugzilla – Bug 83964
Launcher properties should be integrated into the nautilus properties dialog
Last modified: 2004-12-22 21:47:04 UTC
Launcher properties should be integrated into the nautilus properties dialog, there should not be a seperate edit launchers option in the context menus when in any directory. Also launcher properties should be available for all launchers regardless of the directory they are in.
*** Bug 84045 has been marked as a duplicate of this bug. ***
*** Bug 84356 has been marked as a duplicate of this bug. ***
*** Bug 85970 has been marked as a duplicate of this bug. ***
ccing usability
Sounds sensible to me.
*** Bug 91825 has been marked as a duplicate of this bug. ***
*** Bug 93174 has been marked as a duplicate of this bug. ***
where is the "edit launcher options" in the context menu? i don't see it anywhere.
jacob it only appears when you're in the applications:// directory, another reason the current mechanism is bad :)
ok, i see it now. thanks.
i'm working on this...
jacob, i think alex mentioned that he may have started doing some work on this as well so you might want to check with him about it.
i talked to him briefly yesterday and i don't think he started it. here's a patch which implements this. dave, alex, thoughts?
Created attachment 11175 [details] [review] first crack at implementing this [ crack ]
Created attachment 11317 [details] [review] better version of this
tested this against yesterdays cvs It adds a properties tab when within applications:/// other files unchanged ie: no launcher properties for desktop launchers
*** Bug 91366 has been marked as a duplicate of this bug. ***
Adding patch keyword.
Is there any reason why the patch hasnt made it into the tree? - tested it and worked fine
Yes. I reviewed it on the mailing list.
Created attachment 11663 [details] [review] Modified patch (fixes some issues)
I have attached a modified version of Jacob's patch. It contains the following changes. 1. It moves the position of the launcher tab to the end in the properties window. 2. It adds a should_show_launcher() function to be consistant with the emblem and permission code. So, we are not always creating the launcher tab. 3. It fixes ditem_type_changed(). It saves the GNOME_DESKTOP_ITEM_TYPE change. Can I commit this to CVS (HEAD branch)? Thanks, Dennis
Unfortunately this won't happen for 2.2 because of feature freeze. Marking priority high and milestone future.
Also, any new work on this should use the pluggable property pages stuff.
Apologies for the spam- I'm removing 'bugsquad' from some keywords via the web interface. This is a one-time only thing before I re-add bugsquad via the SQL interface, which will generate no mail. Apologies again.
*** Bug 99987 has been marked as a duplicate of this bug. ***
*** Bug 102000 has been marked as a duplicate of this bug. ***
Does this allow you to edit desktop launchers yet? what about launchers in other directories? I see no reason to limit it to applications://
Adding myself to the cc list. mike@redtux.demon.co.uk's first comment and Mark Finlay's comment above seem to imply that desktop launchers have not been included in any of the fixes so far. Is this true? If so, why? Thanks.
See alex's comments above. This patch needs to be reworked to use the nautilus pluggable properties page api.
*** Bug 110728 has been marked as a duplicate of this bug. ***
removing GNOMEVER2.0 and adding myself to cc
Anything happening on this front? seems like bug 105751 is a duplicate of this bug. If it is a .desktop file it should use the launcher-properties right? or should it read the file and find out what it is?
This isn't a dupe of 105751, really, though tangentially related. Reassigning to dave.
Removing patch since the patch is no longer applicable.
*** Bug 117905 has been marked as a duplicate of this bug. ***
*** Bug 140323 has been marked as a duplicate of this bug. ***
*** Bug 123057 has been marked as a duplicate of this bug. ***
Comment on attachment 11663 [details] [review] Modified patch (fixes some issues) marking all the patches as obsolete, as per luis' earlier comment.
snorp wanted to work on this, so i'm assigning to him. Some .desktop-specific stuff should probably be done in an extension, but we probably want the icon changing to work directly on the .desktop file if possible.
*** Bug 135782 has been marked as a duplicate of this bug. ***
It seems it is now possible to edit launcher properties from nautilus properties page. Can this bug be closed, or is there still work to do on this ?
Yep, this is done. Closing.