GNOME Bugzilla – Bug 82591
Maze filter: user interface should be more consistent with other filters.
Last modified: 2005-07-28 15:09:54 UTC
The user interface for the Maze filter is quite unlike other gimp plugins: the layout is a bit messy and doesn't follow standards like using a spinbutton for numerical entries.
There is a dependency between the width or height and the number of pieces (rows or columns). If they are converted to spinbuttons for the numerical entries, then they should probably be put side-by-side, so there would be one line for the width and the corresponding number of pieces (columns) and a second line for the height and the corresponding number of pieces (rows).
Changing milestone on a bunch of bugs to 2.0 - none of these could be considered a blocker for a pre-release, IMHO. Many of these have patches or someone working on them, but they're not urgent. Dave.
I don't think this should be blocking the 2.2 release.
IMO it would be completely sufficient to have two sliders to determine how many pieces are to be generated horizontally and vertically. The resulting size of a single pixel could be displayed in a label. This should be an easy fix for someone who has already done some GTK+ programming but it would also be suitable for a newbie.
Created attachment 39694 [details] Mockup I have attached a UI proposal. Sliders are IMO not the best way to adjust the number of slides since the range would have to be pretty high thus making it potentially harder to use. I personally do not know what exactly the radio buttons are supposed to do, perhaps better labels are a good idea. Can somebody come up with a better description?
Created attachment 39695 [details] Tileable switch added Forgot to add an option. New proposal appended.
Very nice! Now we just need someone to implement this proposal...
Looks nice. Of course adding a preview would make it even cooler ;) The radio buttons just have the name of the 2 algorithms that are used to generate the maze. Maybe they could be put in a GimpFrame: Maze algorithm O Depth first O Prim
Ouch. Forget that last comment. I overlooked that there is already a frame with `Algorithm'
Created attachment 48302 [details] [review] First cut at altering UI as suggested. This is a first cut at altering the UI to match the suggested layout as shown in the attached image and is submitted for review/cleanup. This patch does not change the way the maze size is specified. I'll do that as a separate patch.
2005-06-25 Kevin Cozens <kcozens@cvs.gimp.org> * plug-ins/maze/maze_face.c: First step in changing the UI to match the layout suggested in bug #82591.
What remains to be done here? Kevin, could you add a comment that describes the missing steps that need to be taken in order to close this report?
The originally reported problem has been dealt with. Some of the added comments indicate the plug-in may have room for other improvements. If someone really would like other changes a new bug report should be opened. For now, let's close this report.