GNOME Bugzilla – Bug 82062
[ui-review] Duplicate mnemonics in profile dialog
Last modified: 2004-12-22 21:47:04 UTC
gnome-terminal Edit-> Current Profile is having duplicate shortcut keys General Tab ----------- 1) Alt+u for "Use Same font" and "Use bold version of font" 2) Alt+b for "Blink cursor" and "Silence terminal bell" Title and command tab --------------------- 1) Alt+u for "Update utmp" and "Run a custom command" Scrolling tab ------------- Alt+c for "Scroll on keystroke" and "Close" button Tabs are not having any hot keys
Version 1.9.5 Code taken on 10th May 2002
Sorry the code was taken on 14th May 2002
The tabs aren't supposed to have mnemonics, see the Human Interface Guidelines.
Not sure I understand the comment here. Tomy's not talking about mnemonics on the tab, but on the commands within the tab. In any case, if this is something you don't intend to fix, Havoc, can we just move it off as "WONTFIX"?
It should be fixed in general, I was just commenting on the "Tabs are not having any hot keys" part.
Created attachment 12568 [details] [review] updates to glade file
Added patch for updates that fixes the duplicate mnemonic thing. cc'ing calum to make sure that he reviews the changes. Adding ui-review keyword too, since slightly concerned we may not get all this done by the freeze :/
Updating keywords, adding PATCH.
Yeech, can you just attach diffs to glade files in future? I've no idea what's changed just by looking at that :) Looks fine anyway.
Updating status_whiteboard field to reflect A11Y team's assessment of accessibility impact.
Can this be applied?
It's not a patch, just a whole replacement glade file... I'd edit the glade file by hand to change only the lines that have the mnemonic text, there are other outstanding patches to the glade that I don't want to break due to reindentation etc.
Due to the usability and a11y impact, it would be nice to have this applied. I know conflicts in XML are a PITA...
I just fixed the conflicts myself in CVS.