After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 81868 - hotkey for "read article"
hotkey for "read article"
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
0.11.3
Other Linux
: Normal trivial
: 0.12.0
Assigned To: Charles Kerr
Charles Kerr
Depends on:
Blocks:
 
 
Reported: 2002-05-15 15:21 UTC by william.wu
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description william.wu 2002-05-15 15:21:23 UTC 
Hello !

I am using pan 0.11.2 since 2 hours (I used pan 0.10 before)
so, I notice that I can't read a selected article, by pressing the <r> key
(with pan 0.10 it was <v>) because this key is already assigned to "reply
to the author".

the <space_bar> key "read article" doesn't read the current selected
article but the next article (so it is redundant with shift+<n> "read next
article").
example : given 3 articles A, B, C. I am reading article A, now if I select
article B, how may I read it ? Pressing <space_bar>, pan will read article
C (same as shift+<n>)


I also notice that when pressing any hotkey in the "navigate" menu, the
focus goes to the "article pane". I think if the focus stay on the header
pane : easy navigation with <up>/<down>/<page_up>/<page_down>.
But well you have decided not to includ that minor thing maybe you may keep
"next article" hotkey (shift+<n>) as similar as "previous article" hotkey
(<v>), because this is not easy to remember :)

Thanks for providing such a good software, keep up the good work !
Comment 1 Charles Kerr 2002-05-15 20:42:12 UTC 
IMO the space key function should be changed s.t. when you
change an article focus, that's the article it jumps to.

0.11.93 will have the focus behavior you described between
the header and article pane. :)
Comment 3 william.wu 2002-05-16 16:52:52 UTC 
woaw the source code simple even i don't what the variables are.
I do think that it would be easy to change the number of pixel to
scroll down while pressing <space_bar> key.

on you listing text.c, you scroll down of v->page_size  pixel (I suppose) 
it would be better to scroll down only 
v->page_size - GET.CURRENT_BODY_FONT_SIZE()     pixels
Which means that the last line of the first page will appear on the top
of the second page.

which means that your listing have to be replaced by something like this:

       else { 
          const gfloat new_val =CLAMP(v->value + v->page_size -
              GET.CURRENT_BODY_FONT_SIZE() ,
              v->lower,
              MAX(v->upper,v->page_size)-MIN(v->upper,v->page_size));

          /* or jump down a page */
          gtk_adjustment_set_value (v, new_val);
       }

I am not sure of my code since I have no idea of what are exactly the
parameter of the function CLAMP, but I guess I did make a *big* mistake
(or I hope so).

Thank you for fixing my request so quickly.
And thank you for reading my lame english :)