After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 81626 - XMLizing tasks
XMLizing tasks
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-0.12.0 betas
Other Linux
: Normal normal
: 0.13.0
Assigned To: Charles Kerr
Charles Kerr
Depends on:
Blocks:
 
 
Reported: 2002-05-13 10:34 UTC by Colin Leroy
Modified: 2006-06-18 05:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (to apply with -p1) (9.08 KB, patch)
2002-05-13 10:35 UTC, Colin Leroy
none Details | Review
second version (18.67 KB, patch)
2002-05-15 17:28 UTC, Colin Leroy
none Details | Review
oups, last one was a bad one :-/ (18.67 KB, patch)
2002-05-15 17:32 UTC, Colin Leroy
none Details | Review

Description Colin Leroy 2002-05-13 10:34:45 UTC
Hi,

Here's a first draft for saving the tasks to XML. It's unoptimized, though,
but comments are welcome.

Regards,
Colin
Comment 1 Colin Leroy 2002-05-13 10:35:15 UTC
Created attachment 8425 [details] [review]
patch (to apply with -p1)
Comment 2 Charles Kerr 2002-05-13 12:19:59 UTC
will review asap
Comment 3 Charles Kerr 2002-05-13 16:40:41 UTC
A good first draft... a couple of things to look at:

* it would be good to move this out of queue.c into task-xml.c
* the queue needs a task_list mutex lock before invoking the save func
* queue.h shouldn't include all those tasks
* message ends with a "/>" rather than a ">"
Comment 4 Colin Leroy 2002-05-15 17:28:47 UTC
Created attachment 8494 [details] [review]
second version
Comment 5 Colin Leroy 2002-05-15 17:31:50 UTC
the new patch loads the xml file at startup time, and recreates the tasks.
The parser isn't very powerful yet, but works.
Comment 6 Colin Leroy 2002-05-15 17:32:36 UTC
Created attachment 8495 [details] [review]
oups, last one was a bad one :-/
Comment 7 Charles Kerr 2002-05-15 20:20:07 UTC
This patch is getting there. A more comments:

* task_lock already exists; we don't need a duplicate mutex
* task-*.c doesn't need to include task.h directly; task-*.h does it.
* 60 seconds is too long because of the keepalives - is 30 ok?
* You _*really*_ need to use libxml2 for parsing in task-xml
Comment 8 Charles Kerr 2002-05-17 22:24:41 UTC
examples of libxml2 use can be found in the filters and rules xml
readers btw...
Comment 9 Charles Kerr 2002-05-19 01:24:47 UTC
moving to 0.12.1
Comment 10 Charles Kerr 2002-05-24 21:01:49 UTC
colin: ping :)
Comment 11 Charles Kerr 2002-06-10 21:33:13 UTC
moving feature requests to 0.13.0.
0.12.x releases will be used for bugfixes.
Comment 12 Charles Kerr 2002-07-07 03:39:46 UTC
It took starting it, reworking most of the queue and task hierarchy to
not ref Articles but rather use the new MessageIdentifer class, and
then back around to finishing task-xml.c, but ... this is finally done.

Pan now restores tasks when you restart.