GNOME Bugzilla – Bug 81626
XMLizing tasks
Last modified: 2006-06-18 05:14:47 UTC
Hi, Here's a first draft for saving the tasks to XML. It's unoptimized, though, but comments are welcome. Regards, Colin
Created attachment 8425 [details] [review] patch (to apply with -p1)
will review asap
A good first draft... a couple of things to look at: * it would be good to move this out of queue.c into task-xml.c * the queue needs a task_list mutex lock before invoking the save func * queue.h shouldn't include all those tasks * message ends with a "/>" rather than a ">"
Created attachment 8494 [details] [review] second version
the new patch loads the xml file at startup time, and recreates the tasks. The parser isn't very powerful yet, but works.
Created attachment 8495 [details] [review] oups, last one was a bad one :-/
This patch is getting there. A more comments: * task_lock already exists; we don't need a duplicate mutex * task-*.c doesn't need to include task.h directly; task-*.h does it. * 60 seconds is too long because of the keepalives - is 30 ok? * You _*really*_ need to use libxml2 for parsing in task-xml
examples of libxml2 use can be found in the filters and rules xml readers btw...
moving to 0.12.1
colin: ping :)
moving feature requests to 0.13.0. 0.12.x releases will be used for bugfixes.
It took starting it, reworking most of the queue and task hierarchy to not ref Articles but rather use the new MessageIdentifer class, and then back around to finishing task-xml.c, but ... this is finally done. Pan now restores tasks when you restart.