After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 80977 - Pager-applet displays row where cols is right.
Pager-applet displays row where cols is right.
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: workspace switcher
1.5.x
Other Linux
: High normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-05-06 21:58 UTC by martin H.
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The intial patch (3.78 KB, patch)
2002-05-06 21:59 UTC, martin H.
none Details | Review
new patch (3.79 KB, patch)
2002-05-08 15:40 UTC, martin H.
none Details | Review

Description martin H. 2002-05-06 21:58:39 UTC
In the Preferences dialog of the Pager applet. The user can choose how 
many rows the pager should have. But this is only true for horitontal 
orientation. For vertical Orientation the stetting actually changed how 
many columns the pager has.

How to reproduce:
	Put the Pager on any vertical panel.
	change the "rows" in the preferences.
Expected:
	the layout and the text correspond.
Actual:
	rows and columns are exchanged.

Rationale for patch.
	I think it is reasonable to let the user specify how to devide 
the space that corresponds to the panel size. (You coould argue about 
that). And this is easy to fix this way.

But the situation without the patch is a bit confusing for the user. This 
patch just changes the wrong "Rows" into "cols" if the applet is vertical.
I think this may have an inpact to docs and strings. (Or maybe my patch 
is just on crack, and i should make two glade templates...)
The atk stuff is totally unchanged, so the ATK name will be wrong in the 
vertical case(I don't know about this stuff, and don't like to fiddle 
with things i don't understand)

Also as I'm not an native speaker of english I could not think of any 
reasonable change for the short description in the schema, the long 
description isn't much better.

Anyhow better write a patch to get rolling than just bitching at the 
mailinglist ;-)
Comment 1 martin H. 2002-05-06 21:59:42 UTC
Created attachment 8242 [details] [review]
The intial patch
Comment 2 Heath Harrelson 2002-05-07 06:52:17 UTC
Marking high due to the patch.

Incidentally, I'm not entirely sure this needs the a11y keyword.
Comment 3 Markus Bertheau 2002-05-08 09:53:43 UTC
I think it has to be "Columns" instead of "Cols".
Comment 4 martin H. 2002-05-08 15:39:18 UTC
Just changed "Cols" to "Columns".

I'm still uncertain of the atk stuff(as i don't know how it is used 
how it should be etc).
Comment 5 martin H. 2002-05-08 15:40:02 UTC
Created attachment 8290 [details] [review]
new patch
Comment 6 Alexander Larsson 2002-05-13 02:51:09 UTC
Applied.