After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 80233 - Need to use minimum width for wla so it can be used in flloating and corner panels
Need to use minimum width for wla so it can be used in flloating and corner p...
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: window list
1.5.x
Other other
: Normal minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-04-29 16:31 UTC by Dave Bordoley [Not Reading Bug Mail]
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first patch (25.71 KB, patch)
2002-05-10 18:55 UTC, martin H.
none Details | Review

Description Dave Bordoley [Not Reading Bug Mail] 2002-04-29 16:31:36 UTC
the window list applet doesn't have a minimum width so if i try to put it
in a corner applet horizontally the wla is not possible to use since it
reduces it size to as small as possible.
Comment 1 martin H. 2002-05-08 16:06:23 UTC
I think the right solution would be to have an option to influence 
the size of the tasklist. I think It won't confuse the users too 
much, if we had an option(actually one combo box and an number) that 
let the user restrict the size of the window list applet.
 Havoc said in 
http://mail.gnome.org/archives/desktop-devel-list/2002-April/msg00678.html
that a maximum size option would be ok. I'd suggest a option to 
specify the [maximum|minimum|exact] size.
The other solution would to have such an option for the whole panel.
I have almost the same problem, just on a vertical corner panel, it 
is not unusable with 1 window, but if i have more than 4 windows 
open it uses 2 cols to display them and doesn't expand.

Any better solutions anyone?
Or should I try to implement as described above?

Comment 2 Havoc Pennington 2002-05-08 18:35:38 UTC
For the specific case of the corner panel, it makes more sense to me 
to have the "size" property on the corner panel itself, rather than 
on each applet you might put on the corner panel. Just a thought.
Comment 3 Havoc Pennington 2002-05-09 14:59:21 UTC
Think through all the cases; e.g. if you have a pager in a corner
panel, you probably want it a natural size, rather than a fixed
size... so that's an argument for putting the preference in the tasklist.

Do you want a min/max size here, or do you really just want to set the
exact fixed size? It'd be better to have one spin button in the prefs
dialog instead of that and also an option menu, less clutter.
Comment 4 martin H. 2002-05-10 08:41:34 UTC
I'd be ok (for this case) with a forced size, without minimum or 
maximum options, but the original request was about a minimum size, 
you said You'd likly accept a patch for a maximum size. So I thought 
it would be useful to have them all.
I personaly prefer to have my panel(edge) the same size all the time.
But I'm not sure what is good on a different setup.
bordoley@msu.edu, what would you think about a fixed size?
Comment 5 Dave Bordoley [Not Reading Bug Mail] 2002-05-10 11:19:02 UTC
The actual implementation doesn't matter to me, as long as users can
use the task list on a floating or corner panels. 
Comment 6 martin H. 2002-05-10 18:55:02 UTC
Ok I made a patch that adds a size option to the wla. I isn't yet 
really finished, but it work mostly.
The remaining problems are:
	- It doesn't work at all for edge panels.
	  Maybe we should disable it for them. But on the other hand
	  it would be better if it works in that case, too.
	- Without tuning the options applet is still only the handle
	  on horizontal panels. We need some thing to get it right
	  from the begining.
	- The start size in the options dialog is mostly wrong.
	  I tried to inizialize it to the current (not yet fixed)
	  size, but it doesn't work. And this only makes sense in the
	  case that doesn't work anyway(edge panels)

But is works quit nice on my vertical panel, and quick tests on a 
horizontal panel were nice too.

bordoley@msu.edu, it would be nice if you could test it too...

Comment 7 martin H. 2002-05-10 18:55:53 UTC
Created attachment 8367 [details] [review]
first patch
Comment 8 Luis Villa 2002-05-13 15:52:36 UTC
Adding patch keyword, cc'ing seth in case he has any last second UI
thoughts :)
Comment 9 martin H. 2002-05-26 21:46:06 UTC
I think we should close this bug, because a more universal patch was 
applied by thomas@apestaart.org.
That patch (to libwnck and panel) allows the user to set a minimum 
and a maximum height (or width for vertical panels). It certainly 
solved the problem for me.

Comment 10 Havoc Pennington 2002-05-26 23:14:44 UTC
Sounds good to me...