After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 79812 - Additional chinese font encodings for Solaris
Additional chinese font encodings for Solaris
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
0.23
Other Solaris
: Normal normal
: 1.0.4
Assigned To: Owen Taylor
Owen Taylor
Depends on:
Blocks:
 
 
Reported: 2002-04-24 23:44 UTC by Hidetoshi Tajima
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GB18030/GBK/CNS11643/HKSCS support (474.32 KB, patch)
2002-05-01 19:49 UTC, Qingjiang (Brian) Yuan
none Details | Review
Update patche, please ignore the previous one (475.58 KB, patch)
2002-07-17 22:13 UTC, Qingjiang (Brian) Yuan
none Details | Review

Description Hidetoshi Tajima 2002-04-24 23:44:47 UTC
(Perhaps exclusively)on Solaris platform, more chinese
character sets support are needed by createing a separate 
chinese x11 shaper module, which should solve the problems
described below.

Big5 fonts:
  Solaris uses "big5-1" for BIG5 encoded fonts, while "big5-0"
  is used in the current pango basic X11 shaper.

CNS11643 fonts:
  "cns11643-*" fonts should be primary used in zh_TW.euc locales
GBK fonts
   "gbk-0" fonts should be primary used in zh_CN.gbk locales
GB18030 fonts:
  "gb18030.2000-*" fonts should be primary used in zh_CN.gbk 
  locales.
Comment 1 Owen Taylor 2002-04-30 04:03:46 UTC
Putting on the 1.2 milestone, since 1.0.x is bugfix only.
Comment 2 Hidetoshi Tajima 2002-04-30 18:14:06 UTC
We may add these charsets into basic x shaper instead
of creating a separete chinese shaper. If that's the
case, can we do this on the 1.0.3 milestone?
Comment 3 Owen Taylor 2002-04-30 19:27:27 UTC
If it doesn't involve too drastic changes, yes that would
be possible. (Note that Pango-1.2 is not that far ahead ...
or that different ... it's planned to go along with 
GTK+-2.2, so it should be pretty much frozen before
the end of May.)
Comment 4 Qingjiang (Brian) Yuan 2002-05-01 19:48:06 UTC
Owen,
   I have added GB18030 (gb18030.2000-0 and gb18030.2000-1), GBK
(gbk-0), CNS11643 (cns11643-1, cns11643-2 and cns11643-3) and HKSCS
(hkscs-1) to the basic module, please see the patch I created for the
basic-x.c and tables-big.i.
   I will send you the maps that I used to generate the tables-big.i
in another e-mail, please let me know if you need any more information.

  The following can be added into the ChangLog:
----------------------------------
Tue Apr 30 18:25:08 2002 Qingjiang Yuan <brian.yuan@sun.com>

        * modules/basic/basic-x.c modules/basic/tables-big.i:
        Add GB18030/HKSCS/CNS11643/GBK support. (#79812)
----------------------------------
Best Regards.
Brian.

Comment 5 Qingjiang (Brian) Yuan 2002-05-01 19:49:43 UTC
Created attachment 8103 [details] [review]
GB18030/GBK/CNS11643/HKSCS support
Comment 6 Qingjiang (Brian) Yuan 2002-05-15 17:51:09 UTC
The following lines should be added into the pangox.aliases in order
to  render HKSCS/GB18030/CNS11643/KSX1005(KSC5601.1992-3)for this bug
and bug #78575 in Solaris:

   -*-song-medium-r-normal--*-*-*-*-*-*-*-*,\
   -*-sung-medium-r-normal--*-*-*-*-*-*-*-*,\
   -*-myeongjo-medium-r-normal--*-*-*-*-*-*-*-*,\
Comment 7 Hidetoshi Tajima 2002-05-24 16:20:10 UTC
Okay to commit? - I'd integrate this into 1.2.0 for sure
-so the commit should be done any time soon - right?
(same comments as korean's bugzilla - #78575)
Comment 8 Hidetoshi Tajima 2002-05-29 00:47:20 UTC
retarget this for 1.0.3 - since the fix was made as a pure
bug fix from 1.0.1. Okay to commit today or tomorrow?
Comment 9 Owen Taylor 2002-06-12 16:14:04 UTC
Two comments:

 a) All the entries in charset_orderings should have the
    same total number of entries ... what the language
    tags shuold influence is only the ordering, not
    the set of fonts that might be used.
 b) Just to check, is it really the case that for:

+  { 25, "EUC-TW",       "cns11643-2",	   conv_euctw },
+  { 26, "EUC-TW",       "cns11643-3",	   conv_euctw },

    The cns11643-2 and -3 fonts are non-overlapping
    subsets encoded in the same fashion?
Comment 10 Qingjiang (Brian) Yuan 2002-07-10 20:07:56 UTC
Sorry for late reply, I was on vacation last month.
No problem to have the same number of entries in the
charset_orderings, I didn't put Chinese characters in ko and ja
because I think the performance might be better without checking so
many useless entries.

Yes, the cns11643-2 and -3 are encoded in the same fashion, only the
first two bytes are different, after converting a Unicode to CNS11643,
the third and fourth bytes are enough to locate the glyph in each of
the CNS11643 fonts. We don't need the first two bytes because one
Unicode character only belongs to at most one of the CNS11643 planes,
and it's taken care by the three CNS11643<->Unicode mapping tables:
cns11643-1, cns11643-2 and cns11643-3.
Comment 11 Qingjiang (Brian) Yuan 2002-07-17 22:13:36 UTC
Created attachment 9933 [details] [review]
Update patche, please ignore the previous one
Comment 12 Owen Taylor 2002-07-26 23:51:38 UTC
Applied the patch to HEAD and stable.

Fri Jul 26 19:46:45 2002  Owen Taylor  <otaylor@redhat.com>

        * modules/basic/basic-x.c modules/basic/tables-big.i:
        Patch fromm Qingjiang (Brian) Yuan adding support
        for GB-18030, BIG5-HKSCS, CNS-11643 and GBK encodings.
        Also fix wrong encoding for Big5 fonts and look
        for big5-1 as well as big5-0 for the encoding name.