After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794026 - Port to Meson
Port to Meson
Status: RESOLVED FIXED
Product: five-or-more
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: five-or-more-maint
five-or-more-maint
Depends on:
Blocks:
 
 
Reported: 2018-03-03 16:43 UTC by Robert Roth
Modified: 2018-03-16 01:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Migrate to Meson (6.89 KB, patch)
2018-03-15 17:09 UTC, Ruxandra Simion
none Details | Review
Migrate to Meson (6.90 KB, patch)
2018-03-15 22:26 UTC, Ruxandra Simion
committed Details | Review

Description Robert Roth 2018-03-03 16:43:15 UTC
Porting to meson would speed up the build times, simplify the build maintenance and would also be useful in case of a Vala port.

Details, examples can be found at https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting, 
something recent and similar would be gnome-calculator meson port, see https://git.gnome.org/browse/gnome-calculator/commit/?id=187ad6e033b64b47288562e9c35cad95b829c954
Comment 1 Ruxandra Simion 2018-03-15 17:09:07 UTC
Created attachment 369749 [details] [review]
Migrate to Meson

Hi. I migrated to Meson. Please let me know if I should make any changes. Thank you.
Comment 2 Robert Roth 2018-03-15 18:43:42 UTC
Review of attachment 369749 [details] [review]:

Nice try. Almost perfect, but doesn't work. ninja install fails for a trivial reason. Try running 'ninja install' and you should be able to easily find the problem (in case you don't want to install to the default /usr/local you can specify a prefix when initializing a build directory with meson --prefix=~/ninjadir).
Comment 3 Ruxandra Simion 2018-03-15 22:26:46 UTC
Created attachment 369755 [details] [review]
Migrate to Meson

I think I solved it. Please let me know if there is anything else.
Comment 4 Robert Roth 2018-03-16 01:10:06 UTC
This time it's ok. One minor nitpick: don't put files which do not
exist in EXTRA_DIST, as it causes 'make dist' failure.
Given that autotools will be dropped soon, I have fixed this and
pushed your changes to master.

Attachment 369755 [details] pushed as 4e2c73b - Migrate to Meson