After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793295 - Show a spinner in GdMainIconBoxChild to reflect GdMainBoxItem::pulse
Show a spinner in GdMainIconBoxChild to reflect GdMainBoxItem::pulse
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks: 751212
 
 
Reported: 2018-02-08 10:31 UTC by Debarshi Ray
Modified: 2018-02-12 09:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main-icon-box-child: Show a spinner to reflect GdMainBoxItem::pulse (9.19 KB, patch)
2018-02-08 10:35 UTC, Debarshi Ray 		none Details | Review
main-icon-box-child: Shuffle some code around (7.95 KB, patch)
2018-02-12 09:50 UTC, Debarshi Ray 		committed Details | Review
main-icon-box-child: Show a spinner to reflect GdMainBoxItem::pulse (2.40 KB, patch)
2018-02-12 09:51 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2018-02-08 10:31:59 UTC 
I forgot that I hadn't added a GtkSpinner to GdMainIconBoxChild when I wrote it because there were no applications with which to test. But now it's necessary for marking a collection as busy while adding content to it from a removable device (bug 751212).
Comment 1 Debarshi Ray 2018-02-08 10:35:37 UTC 
Created attachment 368141 [details] [review]
main-icon-box-child: Show a spinner to reflect GdMainBoxItem::pulse
Comment 2 Debarshi Ray 2018-02-12 09:50:36 UTC 
Created attachment 368250 [details] [review]
main-icon-box-child: Shuffle some code around

Splitting up the patch a bit to make it more obvious.
Comment 3 Debarshi Ray 2018-02-12 09:51:07 UTC 
Created attachment 368251 [details] [review]
main-icon-box-child: Show a spinner to reflect GdMainBoxItem::pulse
Comment 4 Debarshi Ray 2018-02-12 09:54:02 UTC 
I pushed these to master to make the 3.27.90 release, but please do let me know if something is wrong or isn't ideal. Sorry for yet another last minute code dump.