After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 79326 - When making things insensitive, doesn't catch their label
When making things insensitive, doesn't catch their label
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other other
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-04-20 17:57 UTC by Havoc Pennington
Modified: 2006-10-17 07:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Proposed patch (6.14 KB, patch)
2005-03-16 21:04 UTC, Michael Terry
none Details | Review
Patch updated to HEAD (4.98 KB, patch)
2006-10-17 07:52 UTC, Mariano Suárez-Alvarez
none Details | Review

Description Havoc Pennington 2002-04-20 17:57:05 UTC
Lots of stuff in profile-editor.c sets a control insensitive but not the 
label for the control.

GTK really needs gtk_widget_get_mnemonic_label(), then you could 
have a nice set_control_and_label_insensitive() utility function,
and automatically set up the labelled-by AtkRelation.
Comment 1 Michael Terry 2005-03-16 21:04:44 UTC
Created attachment 38805 [details] [review]
Proposed patch

I created the utility function you suggested (possible since GTK+ 2.4) and
updated the pre-existing set_insensitive utility function to use it.  Places
that weren't using the set_insensitive function yet were updated to use it.

This is a bit of a brute-force approach, since I changed set_insensitive to
always use the utility function.  It might be better to find each widget that
has a label and only make them call the new utility function.  However, I feel
that this approach is a bit more idiot proof and the performance hit seems
minimal.  If desired, I can rework the patch.

I also had to change the glade file because a label was pointing to the wrong
widget (an internal widget instead of the GnomeFileEntry).
Comment 2 Mariano Suárez-Alvarez 2006-10-17 07:52:36 UTC
Created attachment 74855 [details] [review]
Patch updated to HEAD

This patch is like the old one, but updated to HEAD.

I removed the glade changes: if they are still needed with current gtk/gail/etc, then that should be reported as a bug to them.
Comment 3 Mariano Suárez-Alvarez 2006-10-17 07:59:28 UTC
Fixed in HEAD.

2006-10-17  Mariano Suárez-Alvarez  <msuarezalvarez@arnet.com.ar>

        Bug 79326 – When making things insensitive, doesn't catch their label

        * src/profile-editor.c (profile_editor_update_sensitivity):
        when changing the sensibility of a widget, do the same for its menmonic
        label. Essentially the patch by Michael Terry.