GNOME Bugzilla – Bug 79326
When making things insensitive, doesn't catch their label
Last modified: 2006-10-17 07:59:28 UTC
Lots of stuff in profile-editor.c sets a control insensitive but not the label for the control. GTK really needs gtk_widget_get_mnemonic_label(), then you could have a nice set_control_and_label_insensitive() utility function, and automatically set up the labelled-by AtkRelation.
Created attachment 38805 [details] [review] Proposed patch I created the utility function you suggested (possible since GTK+ 2.4) and updated the pre-existing set_insensitive utility function to use it. Places that weren't using the set_insensitive function yet were updated to use it. This is a bit of a brute-force approach, since I changed set_insensitive to always use the utility function. It might be better to find each widget that has a label and only make them call the new utility function. However, I feel that this approach is a bit more idiot proof and the performance hit seems minimal. If desired, I can rework the patch. I also had to change the glade file because a label was pointing to the wrong widget (an internal widget instead of the GnomeFileEntry).
Created attachment 74855 [details] [review] Patch updated to HEAD This patch is like the old one, but updated to HEAD. I removed the glade changes: if they are still needed with current gtk/gail/etc, then that should be reported as a bug to them.
Fixed in HEAD. 2006-10-17 Mariano Suárez-Alvarez <msuarezalvarez@arnet.com.ar> Bug 79326 – When making things insensitive, doesn't catch their label * src/profile-editor.c (profile_editor_update_sensitivity): when changing the sensibility of a widget, do the same for its menmonic label. Essentially the patch by Michael Terry.