GNOME Bugzilla – Bug 78948
Nautilus crashes when I hit ESC on the "Error while moving" dialog
Last modified: 2009-08-15 18:40:50 UTC
Gnome 2.0 was built on the 15h April from CVS. Description: I try to move a file/folder for which I do not have write permission, using right click. I then hit the ESC key on the dialog which pops up. Nautilus crashes. Steps: 1) Switch over to icon view. Browse to, say, "/etc" folder. 2) Right click on a file/folder (E.g. passwd), drag the item and drop it on the desktop or on another nautilus window. 3) Choose the 'Move' option in the popup menu. 4) The "Error while moving" dialog appears. 5) Hit the ESC key and Nautilus crashes. Debugging info: stack trace attached below. [New Thread 1024 (LWP 2719)] [New Thread 2049 (LWP 2720)] [New Thread 1026 (LWP 2721)] [New Thread 2051 (LWP 2722)] 0x40cfb519 in __wait4 () from /lib/i686/libc.so.6
+ Trace 20943
I just fixed this in CVS.
Anders: Seeing this crash again in a slightly different scenario (i've got an identical stack trace). Ways to reproduce. 1) Copy some files/folders (say 15-20), paste them onto a different location. 2) Interrupt the copying process, by pressing Cancel. 3) Resume copying once again, by pasting into the same folder again, to be prompted for item replace. 4) Press ESC. And the crash occurs. Attaching a fresh copy of the stack trace. [New Thread 1024 (LWP 4532)] [New Thread 2049 (LWP 4535)] [New Thread 1026 (LWP 4536)] [New Thread 2051 (LWP 4537)] [New Thread 3076 (LWP 4538)] [New Thread 4101 (LWP 4539)] [New Thread 5126 (LWP 4540)] 0x40d52519 in __wait4 () from /lib/i686/libc.so.6
+ Trace 23298
Created attachment 8988 [details] [review] handle GTK_RESPONSE_DELETE_EVENT
GtkDialog handles "delete_event" before eel_run_simple_dialog does, so eel never has a chance to circumvent delete_event. This handles the GTK_RESPONSE_DELETE_EVENT return value of gtk_run_dialog the same way it handled GTK_RESPONSE_NONE (ie -1).
Looks fine. Please commit.
Whatever happened to this? Was it committed?
Well, it was only seven hours ago that commit permission was given, and I guarantee dave hasn't been up for any of those seven hours :)
/me smirks in embarassment, thinking he was dealing with a moldy old bug
Checked in.
Dave: I see that the ESC key no longer works on the 'confirm replace' dialog. Is this what should be happening? Or am i seeing something wrong? (I have the 21st June sources from CVS)
That is what should be happening. That code called eel_simple_dialog_run with an ignore_delete_event argument of FALSE. Ignoring the delete_event (which was supposed to ignore esc too) wasn't working.
Ah okay. Closing bug. Thanks :)