After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789196 - Complete support for EXIF orientation values when rendering
Complete support for EXIF orientation values when rendering
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-10-19 12:20 UTC by Debarshi Ray
Modified: 2017-11-26 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gegl: Split out the code to flip a single row of pixels in place (2.23 KB, patch)
2017-11-26 12:21 UTC, Debarshi Ray 		committed Details | Review
quarks: Add the "mirror" orientations (3.70 KB, patch)
2017-11-26 12:21 UTC, Debarshi Ray 		committed Details | Review
gegl: Support the "mirror" orientations (11.21 KB, patch)
2017-11-26 12:22 UTC, Debarshi Ray 		committed Details | Review
base-item: Add the "mirror" orientations to the sanity check (1.53 KB, patch)
2017-11-26 12:23 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-10-19 12:20:46 UTC 
Commit 48577fb5327145a4 (bug 734844) added support for orienting the BaseItems based on the orientation value embedded in their metadata. However, due to lack of test data, it didn't cover all the possible values - only "bottom", "left", "right" and "top".

We should now complete it based on the test images from https://github.com/recurser/exif-orientation-examples
Comment 1 Debarshi Ray 2017-11-22 08:03:48 UTC 
Fixing this might touch upon bug 781736.
Comment 2 Debarshi Ray 2017-11-26 12:21:21 UTC 
Created attachment 364431 [details] [review]
gegl: Split out the code to flip a single row of pixels in place
Comment 3 Debarshi Ray 2017-11-26 12:21:53 UTC 
Created attachment 364432 [details] [review]
quarks: Add the "mirror" orientations
Comment 4 Debarshi Ray 2017-11-26 12:22:26 UTC 
Created attachment 364433 [details] [review]
gegl: Support the "mirror" orientations
Comment 5 Debarshi Ray 2017-11-26 12:23:00 UTC 
Created attachment 364434 [details] [review]
base-item: Add the "mirror" orientations to the sanity check