After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788264 - [patch] Re-enable locale support with glibc ≥ 2.26
[patch] Re-enable locale support with glibc ≥ 2.26
Status: RESOLVED FIXED
Product: libxslt
Classification: Platform
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-28 02:41 UTC by Quentin Minster
Modified: 2017-10-08 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
locale-support-glibc-2.26.patch (938 bytes, text/plain)
2017-09-28 02:41 UTC, Quentin Minster 		Details

Description Quentin Minster 2017-09-28 02:41:05 UTC 
Created attachment 360571 [details]
locale-support-glibc-2.26.patch

Since version 2.26, glibc removed the 'xlocale.h' header (see [1]).
Thus when building libxslt, the configure script fails to find it and disables locale support in libxslt entirely.

Attached is a patch to only include 'xlocale.h' for versions of glibc below 2.26. The patch also touches configure.in to test for locale support even when 'xlocale.h' is missing.

Note that I'm a newbie with the autotools, so it may be that the way I did this is not the Right Way To Do It.

Also, as an additional change I'd suggest renaming the macro XSLT_LOCALE_XLOCALE to XSLT_LOCALE_POSIX since it seems that's what it really is (the other choice being WINAPI, and 'xlocale.h' not being always there anymore).



[1]: https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27
Comment 1 Nick Wellnhofer 2017-10-08 13:47:47 UTC 
Fixed with https://git.gnome.org/browse/libxslt/commit/?id=8b4babb8f742a1a189df4c4569e68eda308df68f

Thanks for the report!