GNOME Bugzilla – Bug 784762
Port to meson build system
Last modified: 2021-06-10 21:16:38 UTC
Created attachment 355289 [details] [review] Port to meson build system It's a complete meson build port. After some testing and file checking, as far as I know, everything I tried is working. It has a minor issue regarding 'uuid' library when compiling the gterminal executable due to missing vapi file. There is an open issue regarding this problem[0]. I have pushed the code to a wip branch just in case someone wants to test it[1]. Any suggestion is very appreciated, [0] https://github.com/mesonbuild/meson/issues/1195 [1] https://git.gnome.org/browse/gnome-terminal/log/?h=wip/inigomartinez/meson
Please get someone interested in meson to review this. I'm not ready to switch to meson, so this will have to be kept in parallel until then, and someone needs to keep it uptodate with any changes in the autotools build. If someone commits to doing that, I'd be ok with having this meson build in g-t git, with the default still being autotools.
Created attachment 357017 [details] [review] Port to meson build system Following my comments[0][1] at 'vte' bug[2], I've also updated [0] https://bugzilla.gnome.org/show_bug.cgi?id=784561#c8 [1] https://bugzilla.gnome.org/show_bug.cgi?id=784561#c9 [2] https://bugzilla.gnome.org/show_bug.cgi?id=784561
Created attachment 357018 [details] [review] Port to meson build system Following my comments[0][1] at 'vte' bug[2], I've also updated the 'gnome-terminal' meson build port. Almost all changes are aesthetic, but the important changes are as follows: - autotools files have modified to include meson files as extra files. - CFLocaleCopyCurrent and CFPreferencesCopyAppValue are only checked on "Mac" systems. - common_flags are warn_flags have been split, so it's clearer now. PS: I'm very sorry about last comment, it was just half written when I pushed Enter and the comment was submitted, and I don't know how to remove it. [0] https://bugzilla.gnome.org/show_bug.cgi?id=784561#c8 [1] https://bugzilla.gnome.org/show_bug.cgi?id=784561#c9 [2] https://bugzilla.gnome.org/show_bug.cgi?id=784561
Created attachment 357019 [details] [review] Remove autotools Just in case removing autotools is considered, this patch removes autotools.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/7753.