After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783228 - build: Add meson support
build: Add meson support
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on: 781321 783227
Blocks: 782980
 
 
Reported: 2017-05-30 04:57 UTC by Florian Müllner
Modified: 2017-06-06 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Add meson support (5.62 KB, patch)
2017-05-30 04:57 UTC, Florian Müllner
none Details | Review
build: Add meson support (5.62 KB, patch)
2017-05-30 05:18 UTC, Florian Müllner
none Details | Review
build: Add meson support (5.54 KB, patch)
2017-05-30 12:19 UTC, Florian Müllner
none Details | Review
build: Add meson support (5.56 KB, patch)
2017-05-30 12:23 UTC, Florian Müllner
none Details | Review
build: Add meson support (5.60 KB, patch)
2017-05-30 13:13 UTC, Florian Müllner
none Details | Review
build: Add meson support (5.50 KB, patch)
2017-05-30 17:05 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-05-30 04:57:53 UTC
See patch.
Comment 1 Florian Müllner 2017-05-30 04:57:57 UTC
Created attachment 352844 [details] [review]
build: Add meson support

Meson is on track to replace autotools as the build system of choice,
so support it in addition to autotools.
Comment 2 Florian Müllner 2017-05-30 05:18:19 UTC
Created attachment 352848 [details] [review]
build: Add meson support

Bump meson_version requirement for python3.sysconfig_path()
Comment 3 Jeremy Bicha 2017-05-30 11:20:32 UTC
Review of attachment 352848 [details] [review]:

Thank you for working on this!

I removed tweaks/tweak_group_shell.py and added these replacements today
tweaks/tweak_group_power.py
tweaks/tweak_group_top_bar.py
tweaks/tweak_group_workspaces.py

https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=702781
I don't plan on renaming any other files now.

Also, gnome-tweak-tool does not ship any gsettings schemas itself so you can remove those lines.
Comment 4 Florian Müllner 2017-05-30 12:19:28 UTC
Created attachment 352865 [details] [review]
build: Add meson support

Meson is on track to replace autotools as the build system of choice,
so support it in addition to autotools.
Comment 5 Florian Müllner 2017-05-30 12:23:43 UTC
Created attachment 352866 [details] [review]
build: Add meson support

Meh, missed some directory prefixes ...
Comment 6 Florian Müllner 2017-05-30 13:13:55 UTC
Created attachment 352870 [details] [review]
build: Add meson support

Meh, the previous versions worked in testing because I had an old 'gtweak' module lying around in the prefix ...

This one's properly tested now.
Comment 7 Jeremy Bicha 2017-05-30 16:48:41 UTC
Florian, oops, there was another rename. gnome-tweak-tool-lid-inhibitor is no longer a generated file.
Comment 8 Florian Müllner 2017-05-30 17:05:57 UTC
Created attachment 352893 [details] [review]
build: Add meson support

No problem, in particular as it results in less code on the meson side as well ...
Comment 9 Jeremy Bicha 2017-06-06 19:25:46 UTC
Review of attachment 352893 [details] [review]:

Thank you!
Comment 10 Jeremy Bicha 2017-06-06 19:26:53 UTC
Please update the jhbuild moduleset at the same time.
Comment 11 Florian Müllner 2017-06-06 21:19:55 UTC
Attachment 352893 [details] pushed as f229074 - build: Add meson support