GNOME Bugzilla – Bug 782346
make distcheck fails because of missing docs/libplanner/html/index.sgml
Last modified: 2017-05-14 22:42:22 UTC
Created attachment 351383 [details] [review] Don't install missing docs/libplanner/html/index.sgml $ make distcheck -- Installing docs/libplanner/html/index.sgml install: cannot stat 'docs/libplanner/html/index.sgml': No such file or directory Makefile:661: recipe for target 'install-data-local' failed make[4]: *** [install-data-local] Error 1 make[4]: Leaving directory 'planner-0.14.6/_build/sub/docs/libplanner' The file existed once, may be generated. Now, it is missing. The minimalistic patch remove reference to the missing file. It does not harm nor does it improve the already broken GTK-Doc stuff. It just refrains from installing an inexistent file. And that make the build process pass the distcheck stage.
The patch seems legit. +1 Although this might be fixed by simply replacing "html/" with "tmpl/" there, and it should work, I don't know why to install the SGML sources by default, especially into the same directory as the generated output. I suppose, once upon a time, shortly after the Big Bang, but before the Initial Revision, the SGML files were located in the same directory (html/) and later on were moved into a separate one (tmpl/), and the installation wasn't properly tested.
(In reply to Andrew Miloradovsky from comment #1) > Although this might be fixed by simply replacing "html/" with "tmpl/" there, > and it should work, Nope, it doesn't. Forget that.
Review of attachment 351383 [details] [review]: You should use `git format-patch` instead of `git diff` to generate the patch. So that it contains all the info needed for a commit.
Created attachment 351404 [details] [review] Don't install missing docs/libplanner/html/index.sgml git format-patch instead of git diff.
Great, thanks a lot. Pushed.