Created attachment 348973 [details] [review]
ui: Use Gdk.Cursor.for_display() instead of Gdk.Cursor.new()

Gdk.Cursor.new() is deprecated and should not be used for
creation of cursor.

Adrien: Got that from the comment. I think you were looking for the function Gdk.Cursor.for_display()

Review of attachment 348973 [details] [review]:

I'm nitpicking, but the shortlogs are supposed to not be longer than 50 chars and the rest of the commit message should not exceed 72 chars per line but should try to feel the lines as much as possible. See https://wiki.gnome.org/Git/CommitMessages.

::: src/ui/display-box.vala
@@ +126,3 @@
 			return;
 
+		window.cursor = show ? null : new Gdk.Cursor.for_display (window.get_display (), Gdk.CursorType.BLANK_CURSOR);

That looks good. :)

For a better readability maybe we should have the display as a variable so this line can be shorter, but it's clearly not a blocker and I'll let you choose which way you prefer.

Created attachment 348992 [details] [review]
ui: Fix deprecation warnings at exit fullscreen

For constructing the cursor, use Gdk.Cursor.for_display() instead of
Gdk.Cursor() which is deprecated.

Attachment 348992 [details] pushed as cba58c4 - ui: Fix deprecation warnings at exit fullscreen