After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780657 - meson: Use dep.get_pkgconfig_variable()
meson: Use dep.get_pkgconfig_variable()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-28 17:50 UTC by Nicolas Dufresne (ndufresne)
Modified: 2017-03-28 18:04 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nicolas Dufresne (ndufresne) 2017-03-28 17:50:53 UTC
We currently uses the pkg-config command line directly, which isn't very nice (at least in tests/check). We should probably use the new get_pkgconfig_variable() method on the dep object.

Note that meson may need to be extended, since the get_pkgconfig_variable() does not allow setting a variable. An example is for bash completion, we set prefix, in order to transform the returned value. With current meson, we'd have to get the prefix, and variable, subtract the prefix and add the configured prefix.
Comment 1 Tim-Philipp Müller 2017-03-28 18:00:50 UTC
Why do we need to bump meson version for this?

get_pkgconfig_variable() was added in 0.36.0 according to Meson docs, and we require Meson >= 0.36.0
Comment 2 Nicolas Dufresne (ndufresne) 2017-03-28 18:04:02 UTC
Apparently not, well, the bash completion will be a git ugly, but should work still.

Commit: 1b3bdf3e10c12532ba363154176d329bada383a2
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=1b3bdf3e10c12532ba363154176d329bada383a2

Author: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date:   Tue Mar 28 14:22:41 2017 -0300

pkgconfig: Do not ever build an installed .pc file


Commit: a7be8815b50b68214074a97e6f2ce84368e16f30
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=a7be8815b50b68214074a97e6f2ce84368e16f30

Author: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date:   Tue Mar 28 14:23:16 2017 -0300

meson: Use get_pkgconfig_variable instead of calling pkg-config ourself

It is avalaible in meson 0.36 which is now are requirement
Commit: 69a10f67a5d353f328f638c671aee7f1c18d03be
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=69a10f67a5d353f328f638c671aee7f1c18d03be

Author: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date:   Tue Mar 28 14:31:34 2017 -0300

meson: Use get_pkgconfig_variable instead of calling pkg-config ourself

It is avalaible in meson 0.36 which is now are requirement

Commit: 4df327a69b9739929433f8bb7eb0c030a70d4e6d
URL:    http://cgit.freedesktop.org/gstreamer/gst-build/commit/?id=4df327a69b9739929433f8bb7eb0c030a70d4e6d

Author: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date:   Tue Mar 28 14:32:24 2017 -0300

uninstalled: Take into account -good pkgconfig uninstalled file

Commit: 6a37782549f25535ea2624b7a9c34a78d45bb626
URL:    http://cgit.freedesktop.org/gstreamer/gst-editing-services/commit/?id=6a37782549f25535ea2624b7a9c34a78d45bb626

Author: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date:   Tue Mar 28 14:25:06 2017 -0300

meson: Use get_pkgconfig_variable instead of calling pkg-config ourself

It is avalaible in meson 0.36 which is now are requirement

Nothing happens on not found dependencies.