GNOME Bugzilla – Bug 779981
Drop VNC-Display "Read Only" option
Last modified: 2017-03-27 11:54:34 UTC
In a conversation about exposing VNC options with jimmac, we came to the conclusion that there's no benefit from having the "Read Only" toggle exposed in the Properties dialog from a client point of view. In the following patch I keep the get_properties method override so we can easily and cleanly add new properties there in the future.
Created attachment 347837 [details] [review] vnc-display: Do not expose "Read only" option There's no benefit on exposing the "Read only" setting from a client point of view.
Since nobody stepped up against this change, I am pushing it. It is just a cosmetic decision of whether we should expose the option or not, and it can be easily reverted if desired. Attachment 347837 [details] pushed as a2ebfb4 - vnc-display: Do not expose "Read only" option
I hope you did look at the logs and relevant discussion in bugzilla before making this decision: https://bugzilla.gnome.org/show_bug.cgi?id=761202 . Please note that most users are not subscribed to bugs.
(In reply to Zeeshan Ali (Khattak) from comment #3) > I hope you did look at the logs and relevant discussion in bugzilla before > making this decision: https://bugzilla.gnome.org/show_bug.cgi?id=761202 . > Please note that most users are not subscribed to bugs. Never mind that bug. Seems this feature has always been there. I misremembered that we added this later because of genuine use case.
(In reply to Zeeshan Ali (Khattak) from comment #3) > I hope you did look at the logs and relevant discussion in bugzilla before > making this decision: https://bugzilla.gnome.org/show_bug.cgi?id=761202 . > Please note that most users are not subscribed to bugs. I did. It didn't seem related at all.
(In reply to Zeeshan Ali (Khattak) from comment #4) > (In reply to Zeeshan Ali (Khattak) from comment #3) > > I hope you did look at the logs and relevant discussion in bugzilla before > > making this decision: https://bugzilla.gnome.org/show_bug.cgi?id=761202 . > > Please note that most users are not subscribed to bugs. > > Never mind that bug. Seems this feature has always been there. I > misremembered that we added this later because of genuine use case. oh, ok then.