After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778167 - general: add support for Meson
general: add support for Meson
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 782980
 
 
Reported: 2017-02-04 07:15 UTC by Ernestas Kulik
Modified: 2017-05-24 11:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
general: add support for Meson (32.52 KB, patch)
2017-02-04 07:15 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (32.87 KB, patch)
2017-02-04 07:54 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (32.89 KB, patch)
2017-02-04 08:35 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (32.91 KB, patch)
2017-02-04 14:19 UTC, Ernestas Kulik
none Details | Review
Drop git.mk (19.97 KB, patch)
2017-02-23 18:36 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (44.79 KB, patch)
2017-02-23 18:37 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (45.35 KB, patch)
2017-02-23 19:05 UTC, Ernestas Kulik
none Details | Review
Drop git.mk (20.12 KB, patch)
2017-02-23 19:05 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (45.36 KB, patch)
2017-02-23 20:00 UTC, Ernestas Kulik
none Details | Review
general: drop git.mk (20.13 KB, patch)
2017-02-23 20:00 UTC, Ernestas Kulik
committed Details | Review
general: add support for Meson (45.40 KB, patch)
2017-02-23 20:34 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (34.20 KB, patch)
2017-02-23 21:49 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (33.92 KB, patch)
2017-02-23 22:13 UTC, Ernestas Kulik
none Details | Review
general: add support for Meson (33.87 KB, patch)
2017-02-23 22:22 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2017-02-04 07:15:50 UTC
This patch adds support for the Meson build system.
Comment 1 Ernestas Kulik 2017-02-04 07:15:57 UTC
Created attachment 344914 [details] [review]
general: add support for Meson
Comment 2 Ernestas Kulik 2017-02-04 07:54:12 UTC
Created attachment 344916 [details] [review]
general: add support for Meson
Comment 3 Ernestas Kulik 2017-02-04 08:35:42 UTC
Created attachment 344919 [details] [review]
general: add support for Meson
Comment 4 Ernestas Kulik 2017-02-04 08:37:59 UTC
Something might still be subtly broken.

So far I’ve fixed:
    libnautilus-extension not being installed,
    libnautilus-extension headers being installed in the wrong dir,
    nautilus-autorun-software not being built,
    LOCALEDIR not being prefixed, resulting in broken translations
Comment 5 Ernestas Kulik 2017-02-04 14:19:56 UTC
Created attachment 344926 [details] [review]
general: add support for Meson

Fixed extensiondir.
Comment 6 Ernestas Kulik 2017-02-23 18:36:10 UTC
Created attachment 346592 [details] [review]
Drop git.mk
Comment 7 Ernestas Kulik 2017-02-23 18:37:20 UTC
Created attachment 346593 [details] [review]
general: add support for Meson
Comment 8 Ernestas Kulik 2017-02-23 19:05:20 UTC
Created attachment 346595 [details] [review]
general: add support for Meson

Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time of roughly one-fifth of what it took Autotools is
more than reason enough to add support for Meson. Along with that, this
commit adds a convenience script
(https://github.com/meitar/git-archive-all.sh) to generate a tarball for
releases, since we use libgd as a submodule and Meson does not handle
source distributions.
Comment 9 Ernestas Kulik 2017-02-23 19:05:29 UTC
Created attachment 346596 [details] [review]
Drop git.mk

This commit removes git.mk and adds hand-written gitignore files. That
is needed to ignore build/, which is the directory of choice for Meson
builds.
Comment 10 Ernestas Kulik 2017-02-23 20:00:00 UTC
Created attachment 346598 [details] [review]
general: add support for Meson

Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script
(https://github.com/meitar/git-archive-all.sh) to generate a tarball for
releases, since we use libgd as a submodule and Meson does not handle
source distributions.
Comment 11 Ernestas Kulik 2017-02-23 20:00:07 UTC
Created attachment 346599 [details] [review]
general: drop git.mk

This commit removes git.mk and adds hand-written gitignore files. That
is needed to ignore build/, which is the directory of choice for Meson
builds.
Comment 12 Ernestas Kulik 2017-02-23 20:34:40 UTC
Created attachment 346601 [details] [review]
general: add support for Meson

Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script
(https://github.com/meitar/git-archive-all.sh) to generate a tarball for
releases, since we use libgd as a submodule and Meson does not handle
source distributions.
Comment 13 Ernestas Kulik 2017-02-23 21:49:00 UTC
Created attachment 346606 [details] [review]
general: add support for Meson

Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script
(https://github.com/meitar/git-archive-all.sh) to generate a tarball for
releases, since we use libgd as a submodule and Meson does not handle
source distributions.
Comment 14 Ernestas Kulik 2017-02-23 22:13:52 UTC
Created attachment 346608 [details] [review]
general: add support for Meson

Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script
(https://github.com/meitar/git-archive-all.sh) to generate a tarball for
releases, since we use libgd as a submodule and Meson does not handle
source distributions.
Comment 15 Carlos Soriano 2017-02-23 22:19:31 UTC
Review of attachment 346599 [details] [review]:

Since we are just matching what git.mk was doing, this looks good to me.

Might worth a revisit of all of this stuff later on when we don't have autotools anymore.
Comment 16 Carlos Soriano 2017-02-23 22:21:19 UTC
Review of attachment 346608 [details] [review]:

As we reviewed on IRC, except for the commit message mentioning the (now unused) git-archive-all, this looks good to me! Impressive work!!!
Comment 17 Ernestas Kulik 2017-02-23 22:22:27 UTC
Created attachment 346609 [details] [review]
general: add support for Meson

Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script to generate a tarball
for releases, since we use libgd as a submodule and Meson does not
handle source distributions.
Comment 18 Ernestas Kulik 2017-02-23 22:25:37 UTC
Attachment 346599 [details] pushed as 7283003 - general: drop git.mk
Attachment 346609 [details] pushed as ed5652c - general: add support for Meson