GNOME Bugzilla – Bug 776043
Notifications are not revoked by the application when focused (or on exit)
Last modified: 2017-02-01 13:00:18 UTC
To quote the HIG[1]: "Notifications in GNOME 3 persist after they have been initially displayed. It is therefore important to remove notification messages that are no longer relevant to the user." I don't think Clocks does this sufficiently. I would expect Clocks to remove its notifications when I exit it or has its window focused. [1] https://developer.gnome.org/hig/stable/notifications.html.en
Created attachment 344695 [details] [review] application: Withdraw system notifications on exit This patch keeps track of the system notifications as they appear and withdraws them when the application quits. The HIG[0] says that "Notifications in GNOME 3 persist after they have been initially displayed. It is therefore important to remove notification messages that are no longer relevant to the user." [0] https://developer.gnome.org/hig/stable/notifications.html.en
Review of attachment 344695 [details] [review]: Thanks! Just one minor nitpick to amend before pushing: please use curly brackets for the foreach even if it is a oneliner
Created attachment 344700 [details] [review] window: Withdraw notifications when the windows is focused Clocks should dismiss (withdraw) its notifications when the windows is focused. The HIG[0] says that "Notifications in GNOME 3 persist after they have been initially displayed. It is therefore important to remove notification messages that are no longer relevant to the user." [0] https://developer.gnome.org/hig/stable/notifications.html.en
Comment on attachment 344695 [details] [review] application: Withdraw system notifications on exit Attachment 344695 [details] pushed as be09d98 - application: Withdraw system notifications on exit
Created attachment 344701 [details] [review] window: Withdraw notifications when the windows is focused Clocks should dismiss (withdraw) its notifications when the windows is focused. The HIG[0] says that "Notifications in GNOME 3 persist after they have been initially displayed. It is therefore important to remove notification messages that are no longer relevant to the user." [0] https://developer.gnome.org/hig/stable/notifications.html.en
Review of attachment 344700 [details] [review]: Thank you!
Review of attachment 344701 [details] [review]: Actually now that I look more closely maybe it is cleaner to connect to the windows signal and keep the withdraw method private
Created attachment 344704 [details] [review] application: Withdraw notifications when the windows is focused Clocks should dismiss (withdraw) its notifications when the windows is focused. The HIG[0] says that "Notifications in GNOME 3 persist after they have been initially displayed. It is therefore important to remove notification messages that are no longer relevant to the user." [0] https://developer.gnome.org/hig/stable/notifications.html.en
Review of attachment 344704 [details] [review]: Looks good
Thank you! Attachment 344704 [details] pushed as b848116 - application: Withdraw notifications when the windows is focused