GNOME Bugzilla – Bug 775891
Improve the presentation of unmount notifications
Last modified: 2017-03-27 18:32:46 UTC
The unmount notifications, that read "You can now unplug <drive>" could look and read better. * Since they are system notifications, it would be better if they used a symbolic icon * Strings generally shouldn't address the user directly. Instead of "You can now...", it would be better to say "<drive> can be safely unplugged" * Notifications should always have a description. In this case, something like "Device can be removed." would work, and might help in situations where "unplugged" isn't quite the right word to use.
The string comes from GVfs. I will prepare patch changing the strings (the symbolic icon should be added by Nautilus). However, there are more strings which can be printed, when unmounting: Notifications, which can be shown when ejecting/stopping drive: - "Writing data to %s\nDon’t unplug until finished" - "You can now unplug %s\n" ---> "% can be safely unplugged\nDevice can be removed." Notifications, which are shown in other cases (for mounts without drives, or if ejecting/stopping is not supported for some reason): - "Unmounting %s\nPlease wait" - "%s has been unmounted\n" Allan, can you please check rest of the notifications also?
OK, here's my attempt at rewriting each of those notifications! 1. Writing data to <device> Device should not be unplugged. 2. <device> can be safely unplugged Device can be removed. 3. Unmounting <device> Please wait to unplug device. 4. <device> unmounted Device can be safely unplugged.
Thanks! The 1. and 2. looks good, but I am not really sure with 3. and 4. Sorry that I haven't described it with more details initially. The problem is that the drive can have multiple volumes/mounts. The 3. and 4. are shown also if you unmount just one of the mounts, so other volumes may be still mounted and it is not safe to unplug the drive (see Bug 774192). So we should not talk about unplugging... Another problem is that it can be shown also when unmounting volume without drive (e.g. whatever from fstab like cifs mount, nfs mount, mounted iso...), so we should not talk about device, because it doesn't have to be actually a device... Do you have any idea what we can do with it?
(In reply to Ondrej Holy from comment #3) ... > Do you have any idea what we can do with it? Something like this, perhaps? 3. Unmounting <filesystem> Disconnecting from filesystem. 4. <device> unmounted Filesystem has been disconnected.
Created attachment 342391 [details] [review] udisks2: Improve unmount notifications Do not address the user directly in the strings. Add a missing description for the notifications.
Created attachment 342392 [details] [review] udisks2: Refactor notification handling The generic_text variable is used currently to determine which strings should be used for notifications. It is TRUE if unmounting (i.e. mount is set) and FALSE otherwise (i.e. drive is set). Remove this variable and make it more obvious...
Allan, thanks, that looks good. So I've provided patches for GVfs, rest should be improved on Nautilus side...
Attachment 342391 [details] pushed as f834b3a - udisks2: Improve unmount notifications Attachment 342392 [details] pushed as c6a3c83 - udisks2: Refactor notification handling
Is this fixed?
(In reply to Allan Day from comment #0) > The unmount notifications, that read "You can now unplug <drive>" could look > and read better. > > * Since they are system notifications, it would be better if they used a > symbolic icon missing > * Strings generally shouldn't address the user directly. Instead of "You > can now...", it would be better to say "<drive> can be safely unplugged" done > * Notifications should always have a description. In this case, something > like "Device can be removed." would work, and might help in situations where > "unplugged" isn't quite the right word to use. done
Hmm, I've seen a symbolic icon on rawhide, so it is probably fixed... Carlos, don't you know?
It was changed in gnome-shell https://git.gnome.org/browse/gnome-shell/commit/?id=d3c050b88d497e87eb54bb3787a122cd282a89f6 Not sure is the app who should say to use a symbolic icon for the notification, but why not, patch upcoming.
Created attachment 347830 [details] [review] window: Use symbolic icon for notifications We prefer symbolic icons, even though gnome-shell now uses symbolic icons anyway for notifications if it's available.
https://git.gnome.org/browse/nautilus/commit/?id=5462e2d7ff21aedd1f3bdbf1d5b50e219f34ffae
Thanks!