After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775306 - codecparsers: h264parse: improve documentation
codecparsers: h264parse: improve documentation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-29 10:14 UTC by Anton Eliasson
Modified: 2016-11-29 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch 1/2 (4.28 KB, patch)
2016-11-29 10:15 UTC, Anton Eliasson
committed Details | Review
patch 2/2 (6.18 KB, patch)
2016-11-29 10:15 UTC, Anton Eliasson
committed Details | Review

Description Anton Eliasson 2016-11-29 10:14:59 UTC
Spell checks, correct capitalization and some rewording to better fit the terms used in the H.264 spec.
Comment 1 Anton Eliasson 2016-11-29 10:15:32 UTC
Created attachment 340964 [details] [review]
patch 1/2
Comment 2 Anton Eliasson 2016-11-29 10:15:53 UTC
Created attachment 340965 [details] [review]
patch 2/2
Comment 3 Tim-Philipp Müller 2016-11-29 10:41:51 UTC
Thanks. The only thing I'm not so sure about is

- * @cbr_flag: Specifies if running in itermediate bitrate mode or constant
+ * @cbr_flag: Specifies if running in constant or intermittent bit rate mode

Is it really 'intermittent bit rate mode', rather than 'variable bitrate mode'?


commit 03615a772a8dfc698f97a6ba3dd7ac064e792890
Author: Anton Eliasson <antone@axis.com>
Date:   Tue Nov 29 11:08:14 2016 +0100

    codecparsers: h264parse: improve documentation commentary
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775306

commit 0e8567a9817f1362cb3816522972d9b356f5aeca
Author: Anton Eliasson <antone@axis.com>
Date:   Tue Nov 29 11:06:43 2016 +0100

    codecparsers: h264parse: docs spellcheck
    
    Spell checks, correct capitalization and some rewording to
    better fit the terms used in the H.264 spec.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775306
Comment 4 Anton Eliasson 2016-11-29 12:12:55 UTC
I actually don't know what cbr_flag is used for, but quoting the standard (ITU-T H.264 02/2016):

> cbr_flag[ SchedSelIdx ] equal to 0 specifies that to decode this bitstream by the HRD using the SchedSelIdx-th CPB specification, the hypothetical stream delivery scheduler (HSS) operates in an intermittent bit rate mode.
> cbr_flag[ SchedSelIdx ] equal to 1 specifies that the HSS operates in a constant bit rate (CBR) mode. When the cbr_flag[ SchedSelIdx ] syntax element is not present, the value of cbr_flag shall be inferred to be equal to 0.

In other places, VBR is mentioned when cbr_flag is not set. I think the spec just use the terms interchangeably.