After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775255 - playstation: Add some missing boot offsets
playstation: Add some missing boot offsets
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
: 772152 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-11-28 16:20 UTC by Mathieu Bridon
Modified: 2017-09-07 06:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playstation: Add some missing boot offsets (1023 bytes, patch)
2016-11-28 16:20 UTC, Mathieu Bridon 		reviewed Details | Review
playstation: Add DiscImageTime (4.88 KB, patch)
2017-07-15 09:47 UTC, Adrien Plazas 		committed Details | Review
playstation: Add DiscFileInfo (4.86 KB, patch)
2017-07-15 09:47 UTC, Adrien Plazas 		committed Details | Review
playstation: Add DiscImage (9.89 KB, patch)
2017-07-15 09:47 UTC, Adrien Plazas 		committed Details | Review
playstation: Add get_playstation_info() (7.30 KB, patch)
2017-07-15 09:48 UTC, Adrien Plazas 		committed Details | Review
playstation: Parse disc images to detect games (4.70 KB, patch)
2017-07-15 09:48 UTC, Adrien Plazas 		committed Details | Review
playstation: Check boundaries of sectors to access (2.65 KB, patch)
2017-07-16 08:50 UTC, Adrien Plazas 		committed Details | Review

Description Mathieu Bridon 2016-11-28 16:20:35 UTC 
I had three games which Games wouldn't list, because it couldn't find
the BOOT header in the files.

Each of the new offset gets one of these games to run.
Comment 1 Mathieu Bridon 2016-11-28 16:20:40 UTC 
Created attachment 340928 [details] [review]
playstation: Add some missing boot offsets
Comment 2 Adrien Plazas 2016-12-02 13:13:42 UTC 
Review of attachment 340928 [details] [review]:

LGTM
Comment 3 Adrien Plazas 2016-12-02 13:17:42 UTC 
Review of attachment 340928 [details] [review]:

You told me on IRC that there may be a better way to solve the problem so let's check that.
Comment 4 Adrien Plazas 2017-07-15 09:47:49 UTC 
Created attachment 355672 [details] [review]
playstation: Add DiscImageTime

This will be used in a subsequent commit to parse PlayStation disc
images.
Comment 5 Adrien Plazas 2017-07-15 09:47:54 UTC 
Created attachment 355673 [details] [review]
playstation: Add DiscFileInfo

This will be used in a subsequent commit to parse PlayStation disc
images.
Comment 6 Adrien Plazas 2017-07-15 09:47:59 UTC 
Created attachment 355674 [details] [review]
playstation: Add DiscImage

This will be used in the next commit to parse PlayStation disc images.
Comment 7 Adrien Plazas 2017-07-15 09:48:04 UTC 
Created attachment 355675 [details] [review]
playstation: Add get_playstation_info()

This will be used in the next commit to parse PlayStation disc images.
Comment 8 Adrien Plazas 2017-07-15 09:48:08 UTC 
Created attachment 355676 [details] [review]
playstation: Parse disc images to detect games

Replace the detection of games and the extraction of data like the disc
ID for lucky guesses of the position of the PlayStation header by proper
parsing of the disc image.

This should detect previously undetected games without any regression.
Comment 9 Adrien Plazas 2017-07-15 09:49:25 UTC 
Attachment 355672 [details] pushed as e254185 - playstation: Add DiscImageTime
Attachment 355673 [details] pushed as 1f85380 - playstation: Add DiscFileInfo
Attachment 355674 [details] pushed as 3a28c93 - playstation: Add DiscImage
Attachment 355675 [details] pushed as 07419cf - playstation: Add get_playstation_info()
Attachment 355676 [details] pushed as 1f52eb5 - playstation: Parse disc images to detect games
Comment 10 Adrien Plazas 2017-07-16 08:50:10 UTC 
Created attachment 355698 [details] [review]
playstation: Check boundaries of sectors to access

Check the boundaries of the sector to access: it shouldn't be negative
and the computation of the offset of the sector shouldn't overflow.
Comment 11 Adrien Plazas 2017-07-16 08:53:49 UTC 
Comment on attachment 355698 [details] [review]
playstation: Check boundaries of sectors to access

Attachment 355698 [details] pushed as b20f70f - playstation: Check boundaries of sectors to access
Comment 12 Adrien Plazas 2017-09-07 06:28:58 UTC 
*** Bug 772152 has been marked as a duplicate of this bug. ***