After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774735 - test-suite failures with newer pep8/pycodestyle: tests/tests.py:105:1: E305 expected 2 blank lines after class or function definition, found 1
test-suite failures with newer pep8/pycodestyle: tests/tests.py:105:1: E305 e...
Status: RESOLVED FIXED
Product: d-feet
Classification: Other
Component: general
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: D-Feet Maintainer(s)
D-Feet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-11-20 00:48 UTC by Michael Biebl
Modified: 2017-11-24 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix PEP8 305 style error (775 bytes, patch)
2016-12-01 17:40 UTC, Michael Biebl
none Details | Review
Fix PEP8 305 style error (1.28 KB, patch)
2017-07-05 21:48 UTC, Michael Biebl
committed Details | Review

Description Michael Biebl 2016-11-20 00:48:48 UTC
Version: 0.3.11
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844533

With pep8 or rather its successor pycodestyle 2.2.0, the test-suite fails
with

  pep8 --max-line-length=99 --ignore=E123,E402 --exclude='.svn,CVS,.bzr,.hg,.git,__pycache__,.#*' ../../src/
  ../../src/tests/tests.py:105:1: E305 expected 2 blank lines after class or function definition, found 1
  Makefile:820: recipe for target 'check-local' failed
  make[5]: *** [check-local] Error 1
  make[5]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11/src/tests'
  Makefile:698: recipe for target 'check-am' failed
  make[4]: *** [check-am] Error 2
  make[4]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11/src/tests'
  Makefile:445: recipe for target 'check-recursive' failed
  make[3]: *** [check-recursive] Error 1
  make[3]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11/src'
  Makefile:389: recipe for target 'check-recursive' failed
  make[2]: *** [check-recursive] Error 1
  make[2]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11'
  debian/rules:9: recipe for target 'override_dh_auto_test' failed
  make[1]: *** [override_dh_auto_test] Error 2
  make[1]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11'
  debian/rules:6: recipe for target 'build' failed
  make: *** [build] Error 2
Comment 1 Michael Biebl 2016-12-01 17:40:44 UTC
Created attachment 341171 [details] [review]
Fix PEP8 305 style error
Comment 2 Michael Biebl 2017-07-05 21:48:22 UTC
Created attachment 354972 [details] [review]
Fix PEP8 305 style error
Comment 3 Michael Biebl 2017-07-05 21:58:40 UTC
Updated the patch for the latest upstream version. Would be great if you can review and apply
Comment 4 Will Thompson 2017-11-24 15:54:25 UTC
Review of attachment 354972 [details] [review]:

I will take the liberty of applying this.
Comment 5 Will Thompson 2017-11-24 15:56:09 UTC
Attachment 354972 [details] pushed as c7b9fe4 - Fix PEP8 305 style error