GNOME Bugzilla – Bug 774735
test-suite failures with newer pep8/pycodestyle: tests/tests.py:105:1: E305 expected 2 blank lines after class or function definition, found 1
Last modified: 2017-11-24 15:56:20 UTC
Version: 0.3.11 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844533 With pep8 or rather its successor pycodestyle 2.2.0, the test-suite fails with pep8 --max-line-length=99 --ignore=E123,E402 --exclude='.svn,CVS,.bzr,.hg,.git,__pycache__,.#*' ../../src/ ../../src/tests/tests.py:105:1: E305 expected 2 blank lines after class or function definition, found 1 Makefile:820: recipe for target 'check-local' failed make[5]: *** [check-local] Error 1 make[5]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11/src/tests' Makefile:698: recipe for target 'check-am' failed make[4]: *** [check-am] Error 2 make[4]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11/src/tests' Makefile:445: recipe for target 'check-recursive' failed make[3]: *** [check-recursive] Error 1 make[3]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11/src' Makefile:389: recipe for target 'check-recursive' failed make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11' debian/rules:9: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 2 make[1]: Leaving directory '/home/lamby/temp/cdt.20161116173756.dheYweAuB8.db.d-feet/d-feet-0.3.11' debian/rules:6: recipe for target 'build' failed make: *** [build] Error 2
Created attachment 341171 [details] [review] Fix PEP8 305 style error
Created attachment 354972 [details] [review] Fix PEP8 305 style error
Updated the patch for the latest upstream version. Would be great if you can review and apply
Review of attachment 354972 [details] [review]: I will take the liberty of applying this.
Attachment 354972 [details] pushed as c7b9fe4 - Fix PEP8 305 style error