After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774629 - decklinkvideosrc: Issue "no signal" warnings
decklinkvideosrc: Issue "no signal" warnings
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-17 16:25 UTC by Vivia Nikolaidou
Modified: 2016-11-18 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-decklinkvideosrc-Issue-no-signal-warnings.patch (2.68 KB, patch)
2016-11-17 16:25 UTC, Vivia Nikolaidou
none Details | Review
0001-decklinkvideosrc-Issue-no-signal-warnings.patch (3.01 KB, patch)
2016-11-17 16:33 UTC, Vivia Nikolaidou
committed Details | Review

Description Vivia Nikolaidou 2016-11-17 16:25:19 UTC
When a frame is found to not have an associated input source (cable
unplugged, wrong mode selected), an element warning will be issued. When
the next frame in the stream is found to have an input source selected
(e.g. cable replugged), an element info will be issued.
Comment 1 Vivia Nikolaidou 2016-11-17 16:25:54 UTC
Created attachment 340141 [details] [review]
0001-decklinkvideosrc-Issue-no-signal-warnings.patch
Comment 2 Sebastian Dröge (slomo) 2016-11-17 16:29:07 UTC
Review of attachment 340141 [details] [review]:

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +660,3 @@
+  flags = f->frame->GetFlags();
+  if (flags & bmdFrameHasNoInputSource) {
+    if (self->no_signal == FALSE) {

Don't compare booleans with ==

@@ +667,3 @@
+  } else {
+    if (self->no_signal) {
+      self->no_signal = FALSE;

You also need to reset it to FALSE (as in init()) whenever the element is restarted.
Comment 3 Vivia Nikolaidou 2016-11-17 16:33:58 UTC
Created attachment 340142 [details] [review]
0001-decklinkvideosrc-Issue-no-signal-warnings.patch

Thanks for the review comments, patch updated.
Comment 4 Sebastian Dröge (slomo) 2016-11-17 16:40:58 UTC
commit 85ef4166a2ab6e871e3efde779d7fd65a3103dc6
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Thu Nov 17 18:23:04 2016 +0200

    decklinkvideosrc: Issue "no signal" warnings
    
    When a frame is found to not have an associated input source (cable
    unplugged, wrong mode selected), an element warning will be issued. When
    the next frame in the stream is found to have an input source selected
    (e.g. cable replugged), an element info will be issued.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774629
Comment 5 Tim-Philipp Müller 2016-11-18 09:56:47 UTC
I think we should be making use of the new _WITH_DETAILS API for error/warning/info messages here, since the error code itself is really quite meaningless and the app can't rely on the error string (might be translated in future) or the debug string (should not be looked at).

Or add a new error code for it.

Or use a different kind of message (maybe progress messages?)