After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773568 - meson: don't add_global_arguments when being built as a subproject
meson: don't add_global_arguments when being built as a subproject
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-27 05:35 UTC by Scott D Phillips
Modified: 2016-11-11 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH gst-plugins-bad] meson: don't add_global_arguments when being built as a subproject (1.09 KB, patch)
2016-10-27 05:42 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-plugins-base] meson: don't add_global_arguments when being built as a subproject (1.09 KB, patch)
2016-10-27 05:42 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-plugins-good] meson: don't add_global_arguments when being built as a subproject (1.09 KB, patch)
2016-10-27 05:43 UTC, Scott D Phillips
committed Details | Review
[PATCH gstreamer] meson: don't add_global_arguments when being built as a subproject (916 bytes, patch)
2016-10-27 05:44 UTC, Scott D Phillips
committed Details | Review

Description Scott D Phillips 2016-10-27 05:35:50 UTC
add_global_arguments() fails the build when meson.is_subproject() is true.
Comment 1 Scott D Phillips 2016-10-27 05:42:06 UTC
Created attachment 338576 [details] [review]
[PATCH gst-plugins-bad] meson: don't add_global_arguments when being built as a subproject
Comment 2 Scott D Phillips 2016-10-27 05:42:40 UTC
Created attachment 338577 [details] [review]
[PATCH gst-plugins-base] meson: don't add_global_arguments when being built as a subproject
Comment 3 Scott D Phillips 2016-10-27 05:43:21 UTC
Created attachment 338578 [details] [review]
[PATCH gst-plugins-good] meson: don't add_global_arguments when being built as a subproject
Comment 4 Scott D Phillips 2016-10-27 05:44:13 UTC
Created attachment 338579 [details] [review]
[PATCH gstreamer] meson: don't add_global_arguments when being built as a subproject
Comment 5 Nirbheek Chauhan 2016-11-11 16:07:17 UTC
This should be accompanied by a patch that adds these warnings to the meson.build in gst-build instead.

I will also note that the list of warning disables isn't comprehensive, so if you have the time it would be nice to get a proper list that gets rid of all useless warnings (without compromising too much on legitimate warnings).
Comment 6 Scott D Phillips 2016-11-11 16:17:40 UTC
(In reply to Nirbheek Chauhan from comment #5)
> This should be accompanied by a patch that adds these warnings to the
> meson.build in gst-build instead.
> 
> I will also note that the list of warning disables isn't comprehensive, so
> if you have the time it would be nice to get a proper list that gets rid of
> all useless warnings (without compromising too much on legitimate warnings).

Yep, I also noticed that the warning list isn't exhaustive and had to turn of Werror. I'll come up with the full list of warnings to disable.
Comment 7 Tim-Philipp Müller 2016-11-11 16:51:27 UTC
Comment on attachment 338579 [details] [review]
[PATCH gstreamer] meson: don't add_global_arguments when being built as a subproject

commit 03286b7b7ec1947c0117047c229c09917f575eb5
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Wed Oct 26 22:38:07 2016 -0700

    meson: don't add_global_arguments when being built as a subproject
    
    https://bugzilla.gnome.org/show_bug.cgi?id=773568
Comment 8 Tim-Philipp Müller 2016-11-11 16:52:00 UTC
Comment on attachment 338577 [details] [review]
[PATCH gst-plugins-base] meson: don't add_global_arguments when being built as a subproject

commit 9ce939a9ae889ca2e6198e595b6b8993282c0e59
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Wed Oct 26 22:37:19 2016 -0700

    meson: don't add_global_arguments when being built as a subproject
    
    https://bugzilla.gnome.org/show_bug.cgi?id=773568
Comment 9 Tim-Philipp Müller 2016-11-11 16:54:16 UTC
Comment on attachment 338578 [details] [review]
[PATCH gst-plugins-good] meson: don't add_global_arguments when being built as a subproject

commit 5a7c3429225a42982834f77d91e0ccb7d8879242
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Wed Oct 26 22:37:34 2016 -0700

    meson: don't add_global_arguments when being built as a subproject
    
    https://bugzilla.gnome.org/show_bug.cgi?id=773568
Comment 10 Tim-Philipp Müller 2016-11-11 16:58:36 UTC
Comment on attachment 338576 [details] [review]
[PATCH gst-plugins-bad] meson: don't add_global_arguments when being built as a subproject

commit ba2908aa2c28a50de84231e9f93ca9032f3eb608
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Wed Oct 26 22:36:17 2016 -0700

    meson: don't add_global_arguments when being built as a subproject
    
    https://bugzilla.gnome.org/show_bug.cgi?id=773568
Comment 11 Tim-Philipp Müller 2016-11-11 16:59:39 UTC
There's https://github.com/mesonbuild/meson/pull/1030 now, so if we can get that into 0.36 we can just use that.