GNOME Bugzilla – Bug 773395
Default bookmarks tag should be localized
Last modified: 2017-01-03 23:06:05 UTC
I see hardcoded in ephy_bookmark_properties_grid_create_tag_widget: default_tag = (g_strcmp0 (tag, "Favorites") == 0); I think that's fine, but we should localize the value before presenting it to the user. It would be a bit ugly, but the pseudocode would be something like: if (g_strcmp0 (tag, "Favorites")) label_text = _("Favorites"); else label_text = tag; And we would do that in the properties grid and the bookmark list popover.
Created attachment 342772 [details] [review] use internationalization for Favorites string I have done as you wanted in both : * src/bookmarks/ephy-bookmark-properties-grid.c * src/bookmarks/ephy-bookmarks-popover.c Furthermore I have added French translation for it. I hope this is OK, maybe you prefer a different patch for it or that I see with the translation team ? Cedric Le Moigne.
Review of attachment 342772 [details] [review]: OK, it looks good, just a couple minor tweaks. Also, please split the French update into a second follow-up patch. ::: src/bookmarks/ephy-bookmark-properties-grid.c @@ +31,3 @@ #include <libsoup/soup.h> #include <string.h> +#include <glib/gi18n.h> Please alphabetize the sections (put it just above libsoup/soup.h). @@ +156,3 @@ GtkStyleContext *context; gboolean default_tag; + char *label_text; We use const/non-const to indicate ownership. Since this variable doesn't hold ownership, please declare it const char *. ::: src/bookmarks/ephy-bookmarks-popover.c @@ +214,1 @@ gtk_box_pack_start (GTK_BOX (box),label, TRUE, FALSE, 0); Since you're modifying the line right above it, you might as well fix the missing space on this line while you're at it.
Created attachment 342780 [details] [review] use internationalization for Favorites after modifications > Also, please split the French update into a second follow-up patch. done > Please alphabetize the sections (put it just above libsoup/soup.h). done > you might as well fix the missing space on this line while you're at it. done
Created attachment 342781 [details] [review] French translation for Favorites string French translation for Favorites string