After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769978 - atomix: Uses deprecated gnome-common macros/variables
atomix: Uses deprecated gnome-common macros/variables
Status: RESOLVED FIXED
Product: atomix
Classification: Other
Component: atomix
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: Atomix Maintainer(s)
Atomix Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-08-16 12:35 UTC by Markus Koschany
Modified: 2016-08-29 23:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port from gnome-common (3.72 KB, patch)
2016-08-20 08:36 UTC, Ernestas Kulik 		committed Details | Review

Description Markus Koschany 2016-08-16 12:35:58 UTC 
Hi,

I'm herby forwarding Debian bug report #829875. Apparently Atomix uses some deprecated macros which may lead to build failures in the future when they get removed.

https://bugs.debian.org/829875


gnome-common did a cleanup upstream and deprecated quite a few macros
and variables.

gnome-doc-utils removal
=======================
The gnome-doc-utils build infrastructure was removed completely along
with the following macros:

 GNOME_DOC_INIT [1]
 GNOME_COMMON_INIT [2]


deprecated variables
====================
The following variables used in gnome-autogen.sh have been declared
deprecated [3]:

 REQUIRED_GNOME_DOC_UTILS_VERSION
 REQUIRED_DOC_COMMON_VERSION
 USE_COMMON_DOC_BUILD
 FORBIDDEN_M4MACROS
 GNOME2_DIR
 GNOME2_PATH
 USE_GNOME2_MACROS

deprecated macros
=================
The following macros have also been declared deprecated:

 GNOME_COMPILE_WARNINGS [4]
 GNOME_CXX_WARNINGS [5]

Upstream has documentation at [6] with how you can fix your package and
why those particular changes were made.


[1] https://git.gnome.org/browse/gnome-common/commit/?id=6684e2fa5
[2] https://git.gnome.org/browse/gnome-common/commit/?id=1f60e9536
[3] https://git.gnome.org/browse/gnome-common/commit/?id=4c8d8ad93
[4] https://git.gnome.org/browse/gnome-common/commit/?id=b57bae0be
[5] https://git.gnome.org/browse/gnome-common/commit/?id=2bffd7e1u
[6] https://wiki.gnome.org/Projects/GnomeCommon/Migration
Comment 1 Ernestas Kulik 2016-08-20 08:36:42 UTC 
Created attachment 333728 [details] [review]
Port from gnome-common

gnome-common has been deprecated for a while now, but some macros are
still being used. This commit replaces them with ones from upstream
autoconf-archive.
Comment 2 Ernestas Kulik 2016-08-20 08:37:29 UTC 
The patch breaks development builds because of -Werror. :)
Comment 3 Ernestas Kulik 2016-08-20 08:41:01 UTC 
(In reply to Ernestas Kulik from comment #2)
> The patch breaks development builds because of -Werror. :)

Or maybe it’s just because I’m distchecking, but I digress.
Comment 4 Robert Roth 2016-08-29 23:25:21 UTC 
Thank you for your contribution.
I have fixed the compile warnings causing the build failure after the port, so the build runs correctly now.
As that is the case, your gnome-common porting effort is pushed to master.
Attachment 333728 [details] pushed as b16edeb - Port from gnome-common