After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769318 - retro: Support gamepad rumble
retro: Support gamepad rumble
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on: 769317
Blocks:
 
 
Reported: 2016-07-30 01:38 UTC by Adrien Plazas
Modified: 2017-11-19 16:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
retro: Make RetroInputManager a RetroGtk.InputDeviceManager (4.45 KB, patch)
2016-08-21 11:49 UTC, Adrien Plazas 		committed Details | Review
retro: Make RetroInputManager implement Retro.Rumble (1.88 KB, patch)
2016-08-21 11:49 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-07-30 01:38:51 UTC 
We should support gamepad rumble as we now support PlayStation games which are using it.

This probably implies looking at how rumble works in evdev.
Comment 1 Adrien Plazas 2016-08-21 11:49:05 UTC 
Created attachment 333807 [details] [review]
retro: Make RetroInputManager a RetroGtk.InputDeviceManager

Make RetroInputManager implement RetroGtk.InputDeviceManager rather than
containing one.
Comment 2 Adrien Plazas 2016-08-21 11:49:18 UTC 
Created attachment 333808 [details] [review]
retro: Make RetroInputManager implement Retro.Rumble

This is needed to avoid some invalid Libretro cores to crash the
application when triggering rumble with a callback.
Comment 3 Adrien Plazas 2016-08-21 11:50:17 UTC 
Attachment 333807 [details] pushed as aaea9cc - retro: Make RetroInputManager a RetroGtk.InputDeviceManager
Attachment 333808 [details] pushed as dfde3c0 - retro: Make RetroInputManager implement Retro.Rumble
Comment 4 Bastien Nocera 2017-03-20 16:59:00 UTC 
Anything left to do here?
Comment 5 Adrien Plazas 2017-03-21 08:28:55 UTC 
(In reply to Bastien Nocera from comment #4)
> Anything left to do here?

Yes, to fix the TODO in Games.RetroInputManager.set_rumble_state(): "// TODO Transmit the rumble signal to the gamepad."

I tried several time to send the rumble signal from the emulator to the gamepads with no success.