After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768787 - AG_GST_PKG_CONFIG_PATH is not called before using GST_PKG_CONFIG_PATH
AG_GST_PKG_CONFIG_PATH is not called before using GST_PKG_CONFIG_PATH
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other FreeBSD
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-13 19:06 UTC by Ting-Wei Lan
Modified: 2016-07-13 23:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure: call AG_GST_PKG_CONFIG_PATH to set GST_PKG_CONFIG_PATH (936 bytes, patch)
2016-07-13 19:09 UTC, Ting-Wei Lan
none Details | Review
configure: Call AG_GST_PKG_CONFIG_PATH to set GST_PKG_CONFIG_PATH (936 bytes, patch)
2016-07-13 19:12 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2016-07-13 19:06:30 UTC
docs/plugins/Makefile sets PKG_CONFIG_PATH to GST_PKG_CONFIG_PATH when building, but GST_PKG_CONFIG_PATH is not set because AG_GST_PKG_CONFIG_PATH is not called in configure.ac. This causes PKG_CONFIG_PATH to be unset and gtkdoc-common.pl cannot be found by common/gstdoc-scangobj:

gmake[3]: Entering directory '/home/lantw44/gnome/source/gst-plugins-good/docs/plugins'
  DOC   Introspecting gobjects
Can't locate gtkdoc-common.pl in @INC (@INC contains: /usr/share/gtk-doc/data /home/lantw44/gnome/devinstall/lib/perl5 /usr/local/lib/perl5 /usr/local/lib/perl5/site_perl/mach/5.20 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.20/mach /usr/local/lib/perl5/5.20 /usr/local/lib/perl5/site_perl/5.20 /usr/local/lib/perl5/site_perl/5.20/mach .) at ../../common/gstdoc-scangobj line 38.
gmake[3]: *** [Makefile:1107: scanobj-build.stamp] Error 1
Comment 1 Ting-Wei Lan 2016-07-13 19:09:51 UTC
Created attachment 331443 [details] [review]
configure: call AG_GST_PKG_CONFIG_PATH to set GST_PKG_CONFIG_PATH

GST_PKG_CONFIG_PATH is used in docs/plugins directory, so
AG_GST_PKG_CONFIG_PATH must be called to set it.
Comment 2 Ting-Wei Lan 2016-07-13 19:12:56 UTC
Created attachment 331444 [details] [review]
configure: Call AG_GST_PKG_CONFIG_PATH to set GST_PKG_CONFIG_PATH

GST_PKG_CONFIG_PATH is used in docs/plugins directory, so
AG_GST_PKG_CONFIG_PATH must be called to set it.
Comment 3 Tim-Philipp Müller 2016-07-13 23:37:03 UTC
Thanks for the patch! I moved the AG_GST_PKG_CONFIG_PATH a bit further down.

commit 74177f9b6fc436ab22bcd9957ca8d964abf9ff5c
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date:   Thu Jul 14 03:07:11 2016 +0800

    configure: Call AG_GST_PKG_CONFIG_PATH to set GST_PKG_CONFIG_PATH
    
    GST_PKG_CONFIG_PATH is used in docs/plugins directory, so
    AG_GST_PKG_CONFIG_PATH must be called to set it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768787