GNOME Bugzilla – Bug 768557
Replace deprecated GNOME_COMPILE_WARNINGS with AX_COMPILER_FLAGS
Last modified: 2018-09-24 09:45:45 UTC
The macros in gnome-common (GNOME_COMPILE_WARNINGS in this case) are deprecated. See here for details: https://wiki.gnome.org/Projects/GnomeCommon/Migration This applies to both grilo and grilo-plugins
Created attachment 335880 [details] [review] Patch for Grilo
Created attachment 335881 [details] [review] Patch for Grilo-plugins
Hi Alberto, thanks for the patches. 1) They don't have commit message 2) Soooo many warnings that they will introduce! I would like to include your patch with at least some fixes for this warnings. I'll try to fix some now. Cheers,
Created attachment 338218 [details] [review] tests: fix warnings on thetvdb resolve shows -Wdiscarded-qualifiers and -Wdeclaration-after-statement such as: -Wdiscarded-qualifiers warning: initialization discards ‘const’ qualifier from pointer target type { "CSI: Miami", "CSI - Miami", "78310", "tt0313043" }, ^~~~~~~~~~~~ -Wdeclaration-after-statement such as: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] gint result = g_test_run (); ^~~~
Created attachment 338219 [details] [review] tests: fix warnings on thetvdb resolve stress -Wdiscarded-qualifiers and -Wdeclaration-after-statement such as: -Wdiscarded-qualifiers warning: initialization discards ‘const’ qualifier from pointer target type {"House", "Everybody Dies", 8, 22, ^~~~~~~ -Wdeclaration-after-statement warning: ISO C90 forbids mixed declarations and code gint result = g_test_run (); ^~~~
Created attachment 338220 [details] [review] tests: fix warnings on thetvdb resolve episodes -Wdiscarded-qualifiers and -Wdeclaration-after-statement such as: -Wdiscarded-qualifiers warning: initialization discards ‘const’ qualifier from pointer target type "tt0409591", "446714", "SH774951", "2006-10-05", ^~~~~~~~~~~~ -Wdeclaration-after-statement warning: ISO C90 forbids mixed declarations and code gint result = g_test_run (); ^~~~
Created attachment 338221 [details] [review] tests: fix warnings on vimeo warning: ISO C90 forbids mixed declarations and code gint result = g_test_run (); ^~~~
Created attachment 338222 [details] [review] tests: fix warnings on tmdb preconditions warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] GrlSource *source = test_get_source(); ^~~~~~~~~
Created attachment 338223 [details] [review] tests: fix warnings on tmdb full resolution warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] guint count = grl_data_length (GRL_DATA (media), GRL_METADATA_KEY_REGION); ^~~~~
Created attachment 338224 [details] [review] tests: fix warnings on tmdb fast resolution warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] GrlSource *source = test_get_source(); ^~~~~~~~~
Created attachment 338225 [details] [review] tests: fix warnings on tmdb fast resolution by id warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] GrlSource *source = test_get_source(); ^~~~~~~~~
Created attachment 338226 [details] [review] tests: fix warnings on tmdb missing configuration warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] GrlSource *source = test_get_source(); ^~~~~~~~~
Created attachment 338227 [details] [review] tests: fix warning on games warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] gint result = g_test_run (); ^~~~
Created attachment 338228 [details] [review] examples: fix warnings on example-tmdb All -Wdeclaration-after-statement such as: warning: ISO C90 forbids mixed declarations and code const gchar *title = grl_media_get_title (media); ^~~~~
(1) not yet close to finish warnings in grilo-plugins (2) I don't really mind to squash some of theses patches, i prefer to have them split and squash then having to split later on =) (3) patches welcome!
I think it is better to have separate bugs for grilo / grilo-plugins, as this bug has and will have more patches. This will make patch testing easier with the below git-bz command: [user@git/grilo-plugins]$ git-bz apply 768557 [user@git/grilo]$ git-bz apply <new-bugid> Ref: http://git.fishsoup.net/man/git-bz.html
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/93.