After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766864 - Scrollbar disabled on first entry into event
Scrollbar disabled on first entry into event
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: library-mode
0.23.x
Other Linux
: Normal normal
: 0.24
Assigned To: Shotwell Maintainers
Shotwell Maintainers
: 767262 768503 773500 776855 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-05-25 11:24 UTC by Norbert Preining
Modified: 2017-01-04 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
step 1 - no scroll bar, photos off the screen not accessible (902.82 KB, image/png)
2016-05-25 11:24 UTC, Norbert Preining 		  Details
step 2 - viewing one of the photos of the event (1.60 MB, image/png)
2016-05-25 11:25 UTC, Norbert Preining 		  Details
step 3 - return to event - scrollbar appears, background changes (912.00 KB, image/png)
2016-05-25 11:26 UTC, Norbert Preining 		  Details
Fix background color drawing (1.50 KB, patch)
2016-05-25 21:03 UTC, Jens Georg 		committed Details | Review
Fix scrollbars in event view (1.32 KB, patch)
2016-05-29 20:04 UTC, Jens Georg 		none Details | Review
Delay size_request in CheckerboardLayout (1.46 KB, patch)
2016-05-29 20:09 UTC, Jens Georg 		committed Details | Review

Description Norbert Preining 2016-05-25 11:24:38 UTC 
Created attachment 328504 [details]
step 1 - no scroll bar, photos off the screen not accessible

I see the following misbehavior (in parenthesis the respective screen shot)
* enter into an event with many photos
* background is white, no scrollbar is shown, access to photos off the first screen is not given (bug-step1.png)
* double click one of the photos to view it (bug-step2.png)
* press Esc to return to the event photo list - background is black, scrollbar is available, all photos are accessible. (bug-step3.png)

That is 100% reproducible.

I am running currently shotwell from git HEAD (commmit 3ee6c32d4)

All the best

Norbert
Comment 1 Norbert Preining 2016-05-25 11:25:39 UTC 
Created attachment 328505 [details]
step 2 - viewing one of the photos of the event
Comment 2 Norbert Preining 2016-05-25 11:26:10 UTC 
Created attachment 328506 [details]
step 3 - return to event - scrollbar appears, background changes
Comment 3 Jens Georg 2016-05-25 15:10:13 UTC 
Yeah, I've seen that as well
Comment 4 Jens Georg 2016-05-25 18:34:38 UTC 
Changing the window size "fixes" this as well
Comment 5 Jens Georg 2016-05-25 19:56:02 UTC 
Another observation: On Event pages with just one photo the color stays white unless I resize the main window to be smaller than the size of the GtkDrawingArea (and then the scrollbar appears)
Comment 6 Jens Georg 2016-05-25 21:03:25 UTC 
Created attachment 328533 [details] [review]
Fix background color drawing

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 7 Jens Georg 2016-05-29 14:27:46 UTC 
Comment on attachment 328533 [details] [review]
Fix background color drawing

Attachment 328533 [details] pushed as 7361b3f - Fix background color drawing
Comment 8 Norbert Preining 2016-05-29 14:42:47 UTC 
I confirm that the current git status fixes the *coloring* problem, but not the no-scrollbar problem.

Thanks

Norbert
Comment 9 Jens Georg 2016-05-29 20:04:50 UTC 
Created attachment 328698 [details] [review]
Fix scrollbars in event view

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 10 Jens Georg 2016-05-29 20:09:04 UTC 
Created attachment 328699 [details] [review]
Delay size_request in CheckerboardLayout

If we do a size_request with height = 0, the size_request in do_reflow does
not lead to a re-allocation.

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 11 Norbert Preining 2016-05-30 01:23:06 UTC 
Thanks, this patch seems to fix the problem for me!
Comment 12 Jens Georg 2016-05-30 15:07:12 UTC 
Attachment 328699 [details] pushed as 4a70d87 - Delay size_request in CheckerboardLayout
Comment 13 Jens Georg 2016-06-05 14:08:31 UTC 
*** Bug 767262 has been marked as a duplicate of this bug. ***
Comment 14 Jens Georg 2016-07-07 11:27:50 UTC 
*** Bug 768503 has been marked as a duplicate of this bug. ***
Comment 15 Jens Georg 2016-10-26 11:04:15 UTC 
*** Bug 773500 has been marked as a duplicate of this bug. ***
Comment 16 Jens Georg 2017-01-04 10:51:37 UTC 
*** Bug 776855 has been marked as a duplicate of this bug. ***