After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764972 - dvbsrc: needlessly perform delivery system autodetection twice
dvbsrc: needlessly perform delivery system autodetection twice
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-12 22:38 UTC by Reynaldo H. Verdejo Pinochet
Modified: 2016-04-16 09:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvbsrc: do not autodetect delsys twice (1.68 KB, patch)
2016-04-12 22:38 UTC, Reynaldo H. Verdejo Pinochet 		committed Details | Review

Description Reynaldo H. Verdejo Pinochet 2016-04-12 22:38:15 UTC 
Created attachment 325827 [details] [review]
dvbsrc: do not autodetect delsys twice

By design we open the adapter twice, but performing delsys auto-detection twice too is totally redundant and costly.

Attached patch makes auto-detection happen only 1 time but has the downside of (IMHO correctly) posting the _new_element message with the discovered adapter information once too. Might someone out there be relying on this odd behavior? Would that be enough reason to keep doing this twice?
Comment 1 Reynaldo H. Verdejo Pinochet 2016-04-15 20:52:38 UTC 
Review of attachment 325827 [details] [review]:

Agreed safe on IRC. Pushed as:

commit 34d888220c5a4272f4aec3c5eace8ca2328857c4
Author: Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com>
Date:   Mon Apr 11 23:45:22 2016 -0700

    dvbsrc: do not autodetect delsys twice
    
    The process is dealt with the first time the adapter is
    opened, there is no need to do this again.