After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763975 - decodebin: Modify result of seekable in check_upstream_seekable function
decodebin: Modify result of seekable in check_upstream_seekable function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-21 08:06 UTC by Jimmy Ohn
Modified: 2016-03-24 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
decodebin: Modify result of seekable in check_upstream_seekable function (1.79 KB, patch)
2016-03-21 08:06 UTC, Jimmy Ohn
committed Details | Review

Description Jimmy Ohn 2016-03-21 08:06:10 UTC
Currently, In check_upstream_seekable function, we don't use the seekable variable for result. It just returns FALSE value even though we already declare about the seekable variable. Also, Tim inform to me about the avoiding returns in the middle of such functions. So I suggest this patch for it.
Comment 1 Jimmy Ohn 2016-03-21 08:06:58 UTC
Created attachment 324414 [details] [review]
decodebin: Modify result of seekable in check_upstream_seekable function
Comment 2 Sebastian Dröge (slomo) 2016-03-24 12:28:42 UTC
Attachment 324414 [details] pushed as 090d0d1 - decodebin: Modify result of seekable in check_upstream_seekable function