After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 76367 - G2 Sawfish Appearance uses old sawfish capplet
G2 Sawfish Appearance uses old sawfish capplet
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
unspecified
Other Linux
: Urgent major
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-03-26 04:57 UTC by John Fleck
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proof of principle patch (675 bytes, patch)
2002-03-30 15:35 UTC, John Fleck
none Details | Review

Description John Fleck 2002-03-26 04:57:32 UTC
Open GNOME2 control center.

Click on advanced, then window manager.

Click on Appearance. It opens the old gnome1 sawfish capplet
(sawfish-capplet) rather than the new one (sawfish-ui).
Comment 1 Luis Villa 2002-03-30 07:30:25 UTC
Is this actually a cc problem or a sawfish problem? We should fix it
before release if at all possible... [though this, as a minor bug,
seems prime for a waiver.]
Comment 2 John Fleck 2002-03-30 15:34:28 UTC
No, this is a control center bug. At the risk of posing as a hacker
for a moment, the patch attached below seems to fix this.
gnome-control-center/capplets/desktop-links/Sawfish/meta-properties.desktop
is trying to call sawfih-capplet, when the GNOME2 sawfish's
configuration capplet is actually called sawfish-ui.

I don't begin to pretend that the patch below is the *right* solution,
as  don't understand all the issues involved, but I do point to it as
a proof of principal that something along these lines is required.

And Louie, I disagree that it is minor and prime for a waiver. Not
being able to configure sawfish from the control center, and having to
know the command line to do it instead, seems major to me.
Comment 3 John Fleck 2002-03-30 15:35:30 UTC
Created attachment 7465 [details] [review]
proof of principle patch
Comment 4 Luis Villa 2002-03-30 18:30:07 UTC
Fair enough.
Comment 5 jacob berkman 2002-04-01 18:32:57 UTC
has the capplet code been ported to gome 2?

if it is not going to be, then these patches should go in.

otherwise, this may be a 'sawfish-capplet not ported' issue that wipro
would look at.
Comment 6 Luis Villa 2002-04-01 18:54:06 UTC
cc'ing jody and wipro, since they are the sawfish people, but I'm
fairly certain that sawfish-ui is (at least) ported to gtk2 already.
Comment 7 JeyaSudha 2002-04-03 10:21:44 UTC
Fixed in cvs. ChangeLog entry is:

2002-03-20 JeyaSudha <jeyasudha.duraipandy@wipro.com>

        * Makefile.in:  Change in the path where sawfish configurator
        desktop files are installed in gnome2.

Comment 8 John Fleck 2002-04-03 13:48:37 UTC
This is not fixed. There has been no change to the
meta-properties.desktop.in, which is stil trying to call the old
"sawfish-capplet" rather than the new "sawfish-ui. I rebuilt this
morning - the bug is still there.
Comment 9 Bharat Tewari 2002-04-04 04:27:24 UTC
the sawfish for gnome-2 should be built using the gnome-2 branch 
where the modified sawfish capplet configuration are checked in. On 
the sawfish head, these changes are not put hence it will start the 
old sawfish capplets only as the *desktop.in files will reflect 
calling sawfish-capplet rather than sawfish-ui. 
Try building the sawfish using the gnome-2 branch and then can you 
please verify on this.
Comment 10 JeyaSudha 2002-04-04 05:24:33 UTC
Meta-properties is removed in gnome-2.0 It is mentioned in the
capplet ChangeLog file.

        * desktop-entries/meta-properties.desktop,
        desktop-entries/.order, desktop-entries/.directory: removed

If the old meta-properties.desktop is not removed then it has to be
removed since it is not needed for gnome-2.0
Comment 11 JeyaSudha 2002-04-04 10:57:05 UTC
Gnome-control-center installs the old sawfish capplet desktop files
which overrides the sawfish installation of desktop files.
Gnome-control-center also still have the meta properties desktop files
which has to be removed. This may also cause the old meta properties 
desktop file gets installed
 
Comment 12 John Fleck 2002-04-04 21:04:00 UTC
I'm already using the gnome-2 branch, and was when I first reported
the bug.
Comment 13 jacob berkman 2002-04-04 21:34:23 UTC
fixed in CVS.