GNOME Bugzilla – Bug 761776
Language selection - some languages aren't capitalized
Last modified: 2016-02-15 17:00:43 UTC
Created attachment 320718 [details] screenshot In the language selection screen, some languages aren't capitalized. See français in the attached screenshot, for example.
*** Bug 735536 has been marked as a duplicate of this bug. ***
I think it's better to fix in gnome-desktop so that all users immediately benefit.
Created attachment 320730 [details] [review] gnome-languages: Use g_auto* macros where applicable
Created attachment 320731 [details] [review] gnome-languages: Capitalize language and territory names Translations in iso-codes are inconsistent in their capitalization of language and territory names. That's not under our control, but we can automatically capitalize them since that's how our API consumers expect them to be.
This isn't quite correct; you need at least use g_unichar_totitle() here, not toupper. See http://unicode.org/faq/casemap_charprop.html#4 .
Created attachment 320883 [details] [review] gnome-languages: Capitalize language and territory names -- Ok, changed it to use _totitle() instead. I'm unsure if the assumption that the character that needs changing is only the first one holds or not. But g_unichar_totitle() works on a single character anyway so I suppose the assumption is ok? If it isn't then shouldn't we have a g_utf8_totitle() that does the work on a whole string and knows how many characters to change?
Review of attachment 320883 [details] [review]: Looks ok to me.
Attachment 320730 [details] pushed as 389a376 - gnome-languages: Use g_auto* macros where applicable Attachment 320883 [details] pushed as 104fb3d - gnome-languages: Capitalize language and territory names