GNOME Bugzilla – Bug 761759
Header bar elements are too narrow, aren't aligned with sidebar
Last modified: 2016-02-25 16:35:06 UTC
Created attachment 320702 [details] screenshot Testing 3.19.x with a GNOME Continuous image from 4 days ago: the header bar elements aren't aligned with the sidebar, and they are too narrow. This is causing the "All Contacts" label to be ellipsized. See the attached screenshot.
Created attachment 321352 [details] [review] window: force right_toolbar to have the same size as content pane
Created attachment 321371 [details] [review] window: make content_header_bar a GtkGrid The recent port of GtkBox to Gadgets caused a misalignment of the left_toolbar and the app sidebar. GtkGrid handles the size group alignment properly.
(In reply to Felipe Borges from comment #2) > Created attachment 321371 [details] [review] [review] > window: make content_header_bar a GtkGrid The patch fixes the issue here.
I would love to know more about 'port of gtkbox to gadget caused this'. Any hints as to what has changed ?
Do we have any active gnome-contacts maintainers around who could review and commit this patch ?
(In reply to Matthias Clasen from comment #5) > Do we have any active gnome-contacts maintainers around who could review and > commit this patch ? I'll do it tonight.
Pushed as commit 779912c
Created attachment 322336 [details] [review] window: make content_header_bar a GtkGrid The recent port of GtkBox to Gadgets caused a misalignment of the left_toolbar and the app sidebar. GtkGrid handles the size group alignment properly. Original patch by: Felipe Borges <felipeborges@gnome.org>
This broke Continuous: contacts-window.vala:54.3-54.32: error: cannot convert from Gtk child type `Gtk.Grid' to `Gtk.Box' private Box content_header_bar; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Compilation failed: 1 error(s), 140 warning(s) Makefile:789: recipe for target 'gnome_contacts_vala.stamp' failed Since the Continuous build has been failing for more than 4 hours, I'm going to revert the patch as per: https://mail.gnome.org/archives/desktop-devel-list/2016-January/msg00015.html Feel free to undo the revert when fixing this bug.
(In reply to Emmanuele Bassi (:ebassi) from comment #9) > This broke Continuous: > > contacts-window.vala:54.3-54.32: error: cannot convert from Gtk child type > `Gtk.Grid' to `Gtk.Box' > private Box content_header_bar; > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > Compilation failed: 1 error(s), 140 warning(s) > Makefile:789: recipe for target 'gnome_contacts_vala.stamp' failed > > Since the Continuous build has been failing for more than 4 hours, I'm going > to revert the patch as per: > > > https://mail.gnome.org/archives/desktop-devel-list/2016-January/msg00015.html > > Feel free to undo the revert when fixing this bug. It's fixed now, or so I think. First for some reason `make && make install && make distcheck` passed yesterday on my pc when it shouldn't. Second, although it's only a personal opinion, I feel really bad about the commit being reverted because it was breaking Continuous. I feel like it's not my code anymore, but it's owned/responsibility of the "sheriffs of Continuous".
(In reply to Erick Perez Castellanos from comment #10) > (In reply to Emmanuele Bassi (:ebassi) from comment #9) > > This broke Continuous: > > > > contacts-window.vala:54.3-54.32: error: cannot convert from Gtk child type > > `Gtk.Grid' to `Gtk.Box' > > private Box content_header_bar; > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Compilation failed: 1 error(s), 140 warning(s) > > Makefile:789: recipe for target 'gnome_contacts_vala.stamp' failed > > > > Since the Continuous build has been failing for more than 4 hours, I'm going > > to revert the patch as per: > > > > > > https://mail.gnome.org/archives/desktop-devel-list/2016-January/msg00015.html > > > > Feel free to undo the revert when fixing this bug. > > It's fixed now, or so I think. First for some reason `make && make install > && make distcheck` passed yesterday on my pc when it shouldn't. Maybe Vala had different flags? Or you didn't regenerate the C files? > Second, although it's only a personal opinion, I feel really bad about the > commit being reverted because it was breaking Continuous. I feel like it's > not my code anymore, but it's owned/responsibility of the "sheriffs of > Continuous". I could have pushed the build fix, but I prefer revert + patch to let you, the maintainer, review it first; since you're not on IRC, I could not contact you directly. If I had just fixed the build myself without a review, would you have felt more in control or less? The responsibility of the "build sheriffs" is to keep GNOME, as whole, building. By virtue of having a shared commit bit for Git repositories, we are *all* owners of all modules on git.gnome.org — we *all* share the responsibility to keep GNOME building and working. Ultimately, I consider reverts far less problematic than going around fixing modules behind the back of the maintainer, or having to understand the code base of every single module in the Continuous build.
(In reply to Emmanuele Bassi (:ebassi) from comment #11) > > Ultimately, I consider reverts far less problematic than going around fixing > modules behind the back of the maintainer, or having to understand the code > base of every single module in the Continuous build. Thanks for the response.