Created attachment 319612 [details] [review]
thumbnail factory: Disconnect signal handlers in finalize

We are seeing crashes in Fedora that point at the settings signal
handlers getting run after the thumbnail factory is finalized.
Explicitly disconnecting the handlers in finalize is the right
thing to do, anyway.

Review of attachment 319612 [details] [review]:

Didn't verify the signal connections, assuming that's right.  Just minor style suggestion, but feel free to commit as is too.

::: libgnome-desktop/gnome-desktop-thumbnail.c
@@ +951,3 @@
+      g_hash_table_destroy (priv->mime_types_map);
+      priv->mime_types_map = NULL;
+    }

g_clear_pointer (&priv->mime_types_map, g_hash_table_unref);

etc.  Since you're touching the code anyways.

@@ +963,3 @@
+  if (priv->disabled_types)
+    {
+      g_strfreev (priv->disabled_types);

Could also g_clear_pointer here.

@@ +976,3 @@
+                                            factory);
+      g_object_unref (priv->settings);
+      priv->settings = NULL;

g_clear_object (&priv->settings)

Attachment 319612 [details] pushed as f32c389 - thumbnail factory: Disconnect signal handlers in finalize