GNOME Bugzilla – Bug 75916
Quote characters
Last modified: 2004-12-22 21:47:04 UTC
This patch allows user to specify which chars should be considered as citation markers when found at line beginning. http://colino.net/patches/pan-0.11.2-quote_chars.patch
Created attachment 7311 [details] [review] the patch ; apply with -p1
This patch is a good start, but it breaks text wrapping. Could you look into util-wrap.c and fix this?
Hello Charles, the problem is located at util-wrap.c:82 *pch=='>' should be replaced by is_quote_char(pch, quote_chars) with quote_chars coming from text_quote_chars in prefs.h. The problem is that I can't access text_quote_chars from pan/base/util-wrap.c as it is linked before pan/prefs.c ; I don't understand anything about how to handle dependencies ; if you had hints or the solution, it'll help me nicely :) Thanks, Colin
Oh right I forgot about that. The way to do this is to bump text_quote_chars up into pan/base/base-prefs.[ch]. base_prefs_init() will get another argument taking the quote chars, and the declaration/definition of text_quote_chars will be in base-prefs.[hc]. cheers, Charles
Just as an FYI for posterity's sake, tangentally related to this patch, one of GNKSA's ``SHOULD'' clauses is that when the user requests a followup or an e-mail reply, the quote prefix SHOULD be `>'. So though we may recognize other quote characters in the display for the sake of colorizing/wrapping, we'll still be posting with '>'. See http://www.xs4all.nl/~js/gnksa/gnksa.txt
*** Bug 68159 has been marked as a duplicate of this bug. ***
No problem for gnksa, I didn't want to allow user quoting with | or so... Following is a new patch that fixes quoting when replying (base-prefs.c was exactly what I was looking for without having found it :) Hope it's fine, Colin
Created attachment 7318 [details] [review] the new patch (-p1 as usual)
Created attachment 7319 [details] [review] I didn't see the comment on bug 68159 ; this patch is with ">:|" by default.
Created attachment 7320 [details] [review] i forgot the test directory in the last one, sorry :-/
committed to pan-0-11-fix branch.. :)