After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758832 - [tiff-loader][PATCH] Fix compilation on big endian arches
[tiff-loader][PATCH] Fix compilation on big endian arches
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2015-11-30 10:59 UTC by Rafael Fonseca
Modified: 2015-12-08 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix compilation on big endian (896 bytes, patch)
2015-11-30 10:59 UTC, Rafael Fonseca
none Details | Review

Description Rafael Fonseca 2015-11-30 10:59:32 UTC
Created attachment 316508 [details] [review]
Fix compilation on big endian

The attached patch fixes the following error when compiling in big endian arches:

tiff-load.c: In function 'load_RGBA':
tiff-load.c:508:17: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'end'
       guint row end = row * p->width + p->width;
                 ^
tiff-load.c:508:17: error: 'end' undeclared (first use in this function)
tiff-load.c:508:17: note: each undeclared identifier is reported only once for each function it appears in
tiff-load.c:509:7: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
       guint i;
       ^
tiff-load.c:511:31: error: 'row_end' undeclared (first use in this function)
       for (i = row_start; i < row_end; i++)
                               ^
Makefile:1302: recipe for target 'tiff_load_la-tiff-load.lo' failed
Comment 1 Debarshi Ray 2015-12-08 13:34:43 UTC
This was already fixed in Git master:

commit d2b05d59b451bdb3b7d2bc61f400bd198e3ed295
Author: Nils Philippsen <nils@redhat.com>
Date:   Thu Dec 3 22:09:00 2015 +0100

    fix typo
Comment 2 Debarshi Ray 2015-12-08 13:35:14 UTC
Thanks for the bug (and the patch), though!