After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758809 - Use icons in the selection toolbar
Use icons in the selection toolbar
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.19.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-29 18:54 UTC by Alessandro Bono
Modified: 2015-11-30 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
selection-toolbar: Remove useless GtkRevealer (5.81 KB, patch)
2015-11-29 18:55 UTC, Alessandro Bono
committed Details | Review
selection-toolbar: Port to templates (9.31 KB, patch)
2015-11-29 18:55 UTC, Alessandro Bono
committed Details | Review
selection-toolbar: Use icons (2.15 KB, patch)
2015-11-29 18:56 UTC, Alessandro Bono
committed Details | Review
selection-toolbar: Port to templates (9.75 KB, patch)
2015-11-30 15:26 UTC, Debarshi Ray
committed Details | Review
selection-toolbar: Use icons (2.21 KB, patch)
2015-11-30 16:09 UTC, Debarshi Ray
committed Details | Review

Comment 1 Alessandro Bono 2015-11-29 18:55:22 UTC
Created attachment 316480 [details] [review]
selection-toolbar: Remove useless GtkRevealer
Comment 2 Alessandro Bono 2015-11-29 18:55:41 UTC
Created attachment 316481 [details] [review]
selection-toolbar: Port to templates
Comment 3 Alessandro Bono 2015-11-29 18:56:07 UTC
Created attachment 316482 [details] [review]
selection-toolbar: Use icons
Comment 4 Debarshi Ray 2015-11-30 15:00:17 UTC
Review of attachment 316480 [details] [review]:

Thanks, Alessandro. Looks good. Maybe add a sentence explaining why it is useless - like you did in gnome-documents.
Comment 5 Debarshi Ray 2015-11-30 15:20:49 UTC
Review of attachment 316481 [details] [review]:

Looks good. Some minor issues:

photos-selection-toolbar.ui should be added to EXTRA_DIST in src/Makefile.am.

::: src/photos-selection-toolbar.c
@@ +485,3 @@
+  gtk_widget_class_bind_template_child_private (widget_class, PhotosSelectionToolbar, toolbar_properties);
+  gtk_widget_class_bind_template_child_private (widget_class, PhotosSelectionToolbar, toolbar_collection);
+

Umm... no need for this new line. Just lump them together.

@@ +491,3 @@
+  gtk_widget_class_bind_template_callback (widget_class, photos_selection_toolbar_properties_clicked);
+  gtk_widget_class_bind_template_callback (widget_class, photos_selection_toolbar_collection_clicked);
+

Ditto.
Comment 6 Debarshi Ray 2015-11-30 15:26:51 UTC
Created attachment 316528 [details] [review]
selection-toolbar: Port to templates

Fixed and pushed.
Comment 7 Debarshi Ray 2015-11-30 16:08:35 UTC
Review of attachment 316482 [details] [review]:

Nice patch, Alessandro. One minor thing, though not really your fault:

::: src/photos-selection-toolbar.ui
@@ +67,1 @@
           <property name="action_name">app.delete</property>

Looks like this '<property>...</property>' is being ignored. Moving it higher up before the style tag makes it work. This could be a GTK+ bug.
Comment 8 Debarshi Ray 2015-11-30 16:09:58 UTC
Created attachment 316538 [details] [review]
selection-toolbar: Use icons

Moved the property tag higher up and pushed.