Created attachment 316480 [details] [review]
selection-toolbar: Remove useless GtkRevealer

Created attachment 316481 [details] [review]
selection-toolbar: Port to templates

Created attachment 316482 [details] [review]
selection-toolbar: Use icons

Review of attachment 316480 [details] [review]:

Thanks, Alessandro. Looks good. Maybe add a sentence explaining why it is useless - like you did in gnome-documents.

Review of attachment 316481 [details] [review]:

Looks good. Some minor issues:

photos-selection-toolbar.ui should be added to EXTRA_DIST in src/Makefile.am.

::: src/photos-selection-toolbar.c
@@ +485,3 @@
+  gtk_widget_class_bind_template_child_private (widget_class, PhotosSelectionToolbar, toolbar_properties);
+  gtk_widget_class_bind_template_child_private (widget_class, PhotosSelectionToolbar, toolbar_collection);
+

Umm... no need for this new line. Just lump them together.

@@ +491,3 @@
+  gtk_widget_class_bind_template_callback (widget_class, photos_selection_toolbar_properties_clicked);
+  gtk_widget_class_bind_template_callback (widget_class, photos_selection_toolbar_collection_clicked);
+

Ditto.

Created attachment 316528 [details] [review]
selection-toolbar: Port to templates

Fixed and pushed.

Review of attachment 316482 [details] [review]:

Nice patch, Alessandro. One minor thing, though not really your fault:

::: src/photos-selection-toolbar.ui
@@ +67,1 @@
           <property name="action_name">app.delete</property>

Looks like this '<property>...</property>' is being ignored. Moving it higher up before the style tag makes it work. This could be a GTK+ bug.

Created attachment 316538 [details] [review]
selection-toolbar: Use icons

Moved the property tag higher up and pushed.