After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758151 - rtpgstdepay does not deserialize custom events
rtpgstdepay does not deserialize custom events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.6.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-16 01:06 UTC by Josep Torra Valles
Modified: 2015-12-09 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Unit test that exhibits the issue (4.77 KB, patch)
2015-11-16 01:22 UTC, Josep Torra Valles
committed Details | Review
Proposed fix (1.03 KB, patch)
2015-11-16 01:23 UTC, Josep Torra Valles
none Details | Review
Proposed fix (1.25 KB, patch)
2015-11-16 18:11 UTC, Josep Torra Valles
committed Details | Review

Description Josep Torra Valles 2015-11-16 01:06:52 UTC
Seems that a bug was introduced with http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/gst/rtp?id=3d7b0f30d748ad1c8e2c5d3528bfbdfe21cfde60 and custom events are dropped in the depayloder.
Comment 1 Josep Torra Valles 2015-11-16 01:22:58 UTC
Created attachment 315644 [details] [review]
Unit test that exhibits the issue
Comment 2 Josep Torra Valles 2015-11-16 01:23:40 UTC
Created attachment 315645 [details] [review]
Proposed fix
Comment 3 Sebastian Dröge (slomo) 2015-11-16 07:06:30 UTC
Can you explain in the commit message what exactly the problem is and why this fixes it?
Comment 4 Josep Torra Valles 2015-11-16 18:11:01 UTC
Created attachment 315699 [details] [review]
Proposed fix
Comment 5 Josep Torra Valles 2015-11-17 16:55:09 UTC
Can I push the test and the fix?
Comment 6 Tim-Philipp Müller 2015-11-17 17:03:41 UTC
I believe Wim said on irc the other day that your patch looks good to him, so you should feel free to push both once you're happy with them.
Comment 7 Josep Torra Valles 2015-11-18 01:27:40 UTC
commit 84b6743cf813651a6a6107ab3a875d2108cb6da7
Author: Josep Torra <n770galaxy@gmail.com>
Date:   Sun Nov 15 17:16:29 2015 -0800

    rtpgstdepay: Properly handle backward compat for event deserialization
    
    Actual code is checking for a NULL terminator and a ';' terminator,
    for backward compat, in a chained way that cause all events being rejected.
    The proper condition is to reject the events when terminator isn't
    in ['\0', ';'] set.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758151

commit f8b9360dadf48d24a27011c56f06d784736155d7
Author: Josep Torra <n770galaxy@gmail.com>
Date:   Sun Nov 15 17:11:02 2015 -0800

    tests: rtp-payloading: Test for handling of custom events in rtpgst
    
    Add a simple test that checks proper serialization/deserialization
    of custom events with rtpgstpay and rtpgstdepay.