After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757833 - Provide a shortcuts window
Provide a shortcuts window
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on: 758637
Blocks:
 
 
Reported: 2015-11-09 16:49 UTC by Allan Day
Modified: 2016-08-16 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for shortcut window (4.41 KB, patch)
2016-02-22 15:14 UTC, elias 		committed Details | Review
Add new shortcuts to the shortcuts window (4.96 KB, patch)
2016-03-23 16:36 UTC, Evandro Giovanini 		committed Details | Review
New shortcuts window (39.93 KB, image/png)
2016-03-23 16:38 UTC, Evandro Giovanini 		  Details

Description Allan Day 2015-11-09 16:49:47 UTC 
Since Music doesn't have a menu bar, it would be great to provide a GtkShortcutsWindow so that users can discover available keyboard shortcuts.

More details can be found here: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Comment 1 elias 2016-02-22 15:14:48 UTC 
Created attachment 321851 [details] [review]
Patch for shortcut window

Only the usual shortcuts and "space" for play/pause. I did not find more shortcuts.
Comment 2 Felipe Borges 2016-02-23 10:23:47 UTC 
(In reply to elias from comment #1)
> Created attachment 321851 [details] [review] [review]
> Patch for shortcut window
> 
> Only the usual shortcuts and "space" for play/pause. I did not find more
> shortcuts.

Thank you for your patch. But before we get it, I would like to resolve bug https://bugzilla.gnome.org/show_bug.cgi?id=758637
Comment 3 Evandro Giovanini 2016-03-23 16:36:10 UTC 
Created attachment 324601 [details] [review]
Add new shortcuts to the shortcuts window

This patch adds the new shortcuts for playback and navigation created
in bug #758637 to the shortcuts window.
Comment 4 Evandro Giovanini 2016-03-23 16:38:06 UTC 
Created attachment 324602 [details]
New shortcuts window

This is a screenshot of what the shortcuts window looks like after the previous patch.
Comment 5 Marinus Schraal 2016-05-16 09:18:44 UTC 
Review of attachment 324601 [details] [review]:

Looks good, needs to keyboard nav patch to be updated.
Comment 6 Marinus Schraal 2016-08-16 13:27:44 UTC 
Patches squashed and committed, thanks for your effort.This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.