GNOME Bugzilla – Bug 757828
Provide a shortcuts window
Last modified: 2017-01-17 06:47:55 UTC
Since Evince doesn't have a menu bar, it would be great to provide a GtkShortcutsWindow so that users can discover available keyboard shortcuts and gestures. More details can be found here: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
For a summary of evince shortcuts, see https://git.gnome.org/browse/evince/tree/help/C/shortcuts.page
Created attachment 315235 [details] [review] shell: Add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Created attachment 315236 [details] Screenshot - shortcuts window (page 1)
Created attachment 315237 [details] Screenshot - shortcuts window (page 2)
Review of attachment 315235 [details] [review]: We need to bump the version requirement in configure.ac as well.
Created attachment 315389 [details] [review] shell: Add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
we might want to add some Gesture shortcuts too, right?
Review of attachment 315389 [details] [review]: Thanks for the patch, would it be possible to do this depending on the GTK version instead of bumping the requirements? ::: shell/evince.gresource.xml @@ +22,1 @@ <gresource prefix="/org/gnome/evince/shell"> Maybe we can just rename this one, and add all resources here.
(In reply to Felipe Borges from comment #7) > we might want to add some Gesture shortcuts too, right? Yes, we have some gestures too.
Created attachment 316664 [details] [review] shell: Add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
(In reply to Carlos Garcia Campos from comment #9) > (In reply to Felipe Borges from comment #7) > > we might want to add some Gesture shortcuts too, right? > > Yes, we have some gestures too. we can go with just the keys for now, just like gnome-documents, and get the gestures included later when gtk+ is "more" ready.
(In reply to Germán Poo-Caamaño from comment #5) > Review of attachment 315235 [details] [review] [review]: > > We need to bump the version requirement in configure.ac as well. as we discussed IRL, as long as we are not adding the entry to the app-menu now, we don't need to bump the version. GtkApplication (in the current version 3.16) is not going to add_accelerator for the help-overlay, so the ShortcutsWindow will be "disabled" for old versions of Gtk.
Created attachment 316669 [details] [review] shell: Add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Created attachment 316670 [details] screenshot (In reply to Felipe Borges from comment #11) > (In reply to Carlos Garcia Campos from comment #9) > > (In reply to Felipe Borges from comment #7) > > > we might want to add some Gesture shortcuts too, right? > > > > Yes, we have some gestures too. > > we can go with just the keys for now, just like gnome-documents, and get the > gestures included later when gtk+ is "more" ready. nevermind. the patch above already contains the touchpad gestures.
Comment on attachment 316669 [details] [review] shell: Add shortcuts help window Thanks
Comment on attachment 316669 [details] [review] shell: Add shortcuts help window Pushed at https://git.gnome.org/browse/evince/commit/?id=6e454ee8f362fcce647ec875406451b4f5cd394f
(In reply to Felipe Borges from comment #1) > For a summary of evince shortcuts, see > https://git.gnome.org/browse/evince/tree/help/C/shortcuts.page Do you know that the page isn't up-to-date also? Some shortcuts do not work, GConf isn't used etc.