After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757827 - Provide a shortcuts window
Provide a shortcuts window
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-09 16:33 UTC by Allan Day
Modified: 2015-12-12 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first result (81.00 KB, image/png)
2015-11-15 18:38 UTC, Felix Riemann
Details
second try (77.88 KB, image/png)
2015-11-23 18:56 UTC, Felix Riemann
Details

Description Allan Day 2015-11-09 16:33:59 UTC
Since eog doesn't have a menu bar, it would be great to provide a GtkShortcutsWindow so that users can discover available keyboard shortcuts and gestures.

More details can be found here: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Comment 1 Felix Riemann 2015-11-15 18:38:29 UTC
Created attachment 315635 [details]
first result

Got this by following the list of shortcuts from the manual.

The order probably has to be changed a bit as eog supports more than two touch gestures. Maybe I'll even place the gestures in the respective categories (switching, zooming, rotating). What's the plan with the gesture icons, will they be included in the icon theme?

Also we should probably try to keep the gesture descriptions in sync over all applications.

It's a bit clunky that the window has to be built by hand by writing the XML. Glade doesn't seem to have support yet. :(
Comment 2 Allan Day 2015-11-16 17:25:22 UTC
(In reply to Felix Riemann from comment #1)
...
> What's the plan with the gesture
> icons, will they be included in the icon theme?

Matthias has suggested that we include them in GTK+ directly. I've filed bug 758187 for that.

> Also we should probably try to keep the gesture descriptions in sync over
> all applications.

That's true. I wonder what the best way to do that would be...
Comment 3 Allan Day 2015-11-16 17:36:27 UTC
(In reply to Felix Riemann from comment #1)
> Created attachment 315635 [details]
> first result

Looks good. A few thoughts:

 * I wouldn't start with touchpad gestures. I agree it would be interesting to try and integrate these into the other sections.
 * Group headings should use header capitalisation [1]
 * "Opening, closing, saving and printing" is a rather long heading title, and it's just a list of actions. "General", maybe?
 * "Viewing images" heading - considering that this is an image viewer, that could mean almost anything. "Browsing"?
 * I don't really like Miscellaneous as a heading. It doesn't tell you anything useful about what's in the group. You could merge F9 into the Browsing section, and put everything else into the general one, possibly.
 * You might want to consider listing F1 and Ctrl+Q, also.
Comment 4 Allan Day 2015-11-23 12:51:12 UTC
Bug 758187 has now been fixed - GTK+ provides the gesture graphics itself. Just let us know if any more are needed.
Comment 5 Felix Riemann 2015-11-23 18:56:08 UTC
Created attachment 316112 [details]
second try

(In reply to Allan Day from comment #4)
> Bug 758187 has now been fixed - GTK+ provides the gesture graphics itself.
> Just let us know if any more are needed.

Nice. The subtitles are standardized too now, I see. :)

(In reply to Allan Day from comment #3)
> (In reply to Felix Riemann from comment #1)
> > Created attachment 315635 [details]
> > first result
> 
> Looks good. A few thoughts:
> 
>  * I wouldn't start with touchpad gestures. I agree it would be interesting
> to try and integrate these into the other sections.

I tried that now. Although it looks a bit odd if you only have small one-key shortcuts mixed with the spacious gestures.

>  * Group headings should use header capitalisation [1]

Yeah, I just copied what was in the help manual

>  * "Opening, closing, saving and printing" is a rather long heading title,
> and it's just a list of actions. "General", maybe?

Ok.

>  * "Viewing images" heading - considering that this is an image viewer, that
> could mean almost anything. "Browsing"?

I went for "Browsing Images" for now.

>  * I don't really like Miscellaneous as a heading. It doesn't tell you
> anything useful about what's in the group. You could merge F9 into the
> Browsing section, and put everything else into the general one, possibly.

Did so.

>  * You might want to consider listing F1 and Ctrl+Q, also.

Okay, I'll try if I can squeeze them into the General section. The first page however will look quite cramped that way though. Maybe I'll have the browsing section change places with the zooming section.
Comment 6 Felix Riemann 2015-12-12 18:23:28 UTC
Okay, had "zooming" and "browsing" switch positions and it looks a bit better.

commit 0f2ae50a53c4ed6e1add01dd8bfcfb97e43b3e44
Author: Felix Riemann <>
Date:   Sat Dec 12 19:21:11 2015 +0100

    EogApplication: Add shortcuts window
    
    Use GtkApplication's automatic shortcut window support
    via GtkBuilder.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757827
---
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.